Skip to content

Explainer doesn't have visit method for PhysicalLayerSchemaCreationStage #5619

Description

@blecourt-private

When explaining a plan for which the PhysicalLayerSchemaCreationStage is created the following error is thrown in the logs:

sqlmesh.core.plan.explainer - ERROR - Unexpected stage: PhysicalLayerSchemaCreationStage (explainer.py:134)

Link to code: https://github.com/TobikoData/sqlmesh/blob/main/sqlmesh/core/plan/explainer.py#L134

It seems that the visit method visit_physical_layer_schema_creation_stage() for this stage is missing from explainer.py.

The corresponding method is defined in evaluator.py: visit_physical_layer_schema_creation_stage().

Activity

  1. added a commit that references this issue on Jul 28, 2026
    6cffcaf
  2. nkwork9999 commented on Jul 28, 2026

    @nkwork9999
    Contributor

    Opened #5925 for this — adds the missing visit_physical_layer_schema_creation_stage to RichExplainerConsole, mirroring the schema derivation in SnapshotEvaluator.create_physical_schemas. test_plan_explain now asserts that no stage is logged as unexpected, which also guards against the same omission for stages added later.

  3. added a commit that references this issue on Jul 28, 2026
    40e26aa
  4. added a commit that references this issue on Aug 7, 2026
    5b8823c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions