feat(connections): Add mssql-python driver.#5839
Open
walanguzzi wants to merge 11 commits into
Open
Conversation
DATETIMEOFFSET is natively supported by `mssql-python`. See "microsoft/mssql-python#213"
- Added a TODO re its removal as it should already be supported natively by `mssql-python`.
chore: Sync upstream `main`.
…sql-python-driver Integrates 63 upstream commits since 4f833af (sqlglot v30, Pydantic 2.13 compat, StarRocks engine, ClickHouse secure field, BigQuery reservations, Databricks connection pool, CI circleci->github migration) while preserving the mssql-python driver support. Auto-merged with zero textual conflicts; all 66 connection-config tests pass. Co-Authored-By: Claude <noreply@anthropic.com>
walanguzzi
force-pushed
the
feature/add-mssql-python-driver
branch
from
00fcd17 to
37f80e7
Compare
walanguzzi
changed the title
mssql-python driver.mssql-python driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue #5645 - support the official
mssql-pythondriver from Microsoft.The new driver implements PEP 249 interfaces and should work as a pluggable drop-in: https://pypi.org/project/mssql-python/
*Re-raises #5647 for clean CI runs following the CircleCI migration.
Motivation
The driver bundles a lightweight and high-performance binary layer replacing the platform's Driver Manager hence eliminating the need for system-level ODBC driver installations.
As per the
mssql-pythonoverview, additional benefits include:mssql-pythonis all that's needed)Code Changes
connect_mssql_pythonand moved the priorpyodbclogic toconnect_pyodbc.driverconfiguration support for"mssql-python"to relevant*ConnectionConfigclasses:MSSQLConnectionConfigAzureSQLConnectionConfigFabricConnectionConfigruffandpylance).Test Plan
The
fast-test,slow-testanddoc-testtargets are also passing (locally).Note
There was initially an issue with
test_state_sync:test_version_schematest case failing and prompting for a migration when run locally. This seems to have been due to my tag-less checkout, fetching the upstream release tags allowedsetuptools-scmto derive the real version string (as it does in CI).Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO