Repository navigation
[Implement] Directory.Build.props and Directory.Packages.props; fixes #404 - #405
Open
samatstariongroup wants to merge 2 commits into
Open
samatstariongroup wants to merge 2 commits into
samatstariongroup wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…404 - Directory.Build.props holds the settings shared by all projects, the NuGet package metadata and VersionPrefix of the library projects, and IsPackable=false plus the common test packages of the test projects - Directory.Packages.props enables Central Package Management and sets the version of every NuGet package - Remove the duplicated settings and package versions from all projects - versionBump.sh updates VersionPrefix in Directory.Build.props and stops on errors - Fix the package title of CDP4ServicesMessaging - Remove the stale CDP4Web - Backup.Tests.csproj - Document the build configuration in CLAUDE.md, AGENTS.md and the update-package-release-notes skill Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Closes #404. Moves the build settings and NuGet package versions that were repeated in every
.csprojinto two files at the repository root (877 lines removed from the project files).Directory.Build.propsCompany,Copyright,RepositoryUrl,LangVersion.Microsoft.Sbom.TargetsandVersionPrefix.Tests):IsPackable=falseand the seven test packages every test project used (NUnit, NUnit.Console, NUnit3TestAdapter, Moq, Microsoft.NET.Test.Sdk, coverlet.collector, coverlet.msbuild)..csprojnow only setsTargetFrameworks,Title,Description,PackageId,PackageReleaseNotes,PackageTagswhere it differs from the default, and its references.Directory.Packages.propsPackageReferenceitems have noVersionattribute any more.Microsoft.NETFramework.ReferenceAssembliesis aGlobalPackageReference.Other changes
versionBump.shupdatesVersionPrefixinDirectory.Build.props, and stops on errors or when the file is missing.CLAUDE.md,AGENTS.mdand theupdate-package-release-notesskill describe where versions now live.CLAUDE.mdandAGENTS.mdalso get corrected target frameworks.CDP4Web.Tests/CDP4Web - Backup.Tests.csproj(targeted net8.0, not in the solution).Package metadata changes (all other package content is unchanged)
CDP4RequirementsVerification-CE,CDP4Rules-CE,CDP4ServicesDal-CEandCDP4Web-CEnow includeprojectUrl; they did not setPackageProjectUrlbefore.CDP4ServicesMessaging-CEhad the title "CDP4Common Community Edition"; it is now "CDP4ServicesMessaging Community Edition".Not changed: the direct references that override vulnerable or outdated transitive dependencies are kept as they were, with their versions now in
Directory.Packages.props.CentralPackageTransitivePinningEnabledis not turned on, because it would add the pinned packages as dependencies of the other published packages. That can be a separate change.Directory.Build.targetsis not added: the repository has no custom targets or logic that must run after the project file.Verification
dotnet build: 0 errors.dotnet test(excludingWebServicesDependentandCICDExclusion): 17 test projects, 2445 passed, 0 failed, on net48 and net10.0.dotnet pack -c Releasebefore and after: the same 12.nupkgand 12.snupkg. File lists (dll, xml docs, pdb, SBOM, icon, README, licence files) and dependency groups are identical; the only nuspec differences are the metadata changes above.dotnet list CDP4-SDK.sln package --outdated --include-transitive(used bynuget-reference-check.yml) still works under Central Package Management.Microsoft.NETFramework.ReferenceAssembliesreference; the CodeQuality workflow on this PR covers it.This PR also contains the commit
[Fix] Target frameworks in CLAUDE.md, which was not yet pushed todevelopment.🤖 Generated with Claude Code