Skip to content

Change default log writing to console instead of Loki. #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToanAtStarionGroup merged 4 commits into from
Sep 1, 2026
Merged

Change default log writing to console instead of Loki. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afecaa9
Change default log writing onto console instead of Loki.
ToanAtStarionGroup Jun 19, 2026
be7b367
Bump Message Pack
ToanAtStarionGroup Jun 22, 2026
f55d56d
Update CDP4MessagePackSerializer-CE to version 30.1.2
ToanAtStarionGroup Jul 2, 2026
8042177
Put test in sequence.
ToanAtStarionGroup Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/CodeQuality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,19 @@ jobs:
run: dotnet restore integration-tests/IntegrationTestSuite/WebservicesIntegrationTests.sln

- name: Run Integration Tests
run: dotnet test integration-tests/IntegrationTestSuite/WebservicesIntegrationTests.sln --logger "trx;LogFileName=test_results.trx" --verbosity detailed
run: |
set +e
dotnet test integration-tests/IntegrationTestSuite/MessagePackIntegrationTests/MessagePackIntegrationTests.csproj \
--settings integration-tests/IntegrationTestSuite/.runsettings \
--logger "trx;LogFileName=msgpack_results.trx" --verbosity detailed
MESSAGEPACK_EXIT=$?
dotnet test integration-tests/IntegrationTestSuite/WebservicesIntegrationTests/WebservicesIntegrationTests.csproj \
--settings integration-tests/IntegrationTestSuite/.runsettings \
--logger "trx;LogFileName=test_results.trx" --verbosity detailed
WEBSERVICES_EXIT=$?
echo "MessagePackIntegrationTests exit code: $MESSAGEPACK_EXIT"
echo "WebservicesIntegrationTests exit code: $WEBSERVICES_EXIT"
[ $MESSAGEPACK_EXIT -eq 0 ] && [ $WEBSERVICES_EXIT -eq 0 ]

- name: Shutdown Integration Test session
run: dotnet-coverage shutdown integrationtestsession
Expand Down
4 changes: 2 additions & 2 deletions CometServer/CometServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ItemGroup>
<PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.0.0" />
<PackageReference Include="Carter" Version="10.0.0" />
<PackageReference Include="CDP4MessagePackSerializer-CE" Version="30.1.0" />
<PackageReference Include="CDP4MessagePackSerializer-CE" Version="30.1.2" />
<PackageReference Include="CDP4ServicesMessaging-CE" Version="30.1.0" />
<PackageReference Include="FluentResults" Version="4.0.0" />
<PackageReference Include="FluentValidation" Version="12.1.1" />
Expand Down Expand Up @@ -93,4 +93,4 @@
<Exec Command="dotnet $(VersionFileCreatorDllPath) path:$(OutDir) " YieldDuringToolExecution="True" ConsoleToMSBuild="True" />
<Message Importance="High" Text="------ VersionFileCreator tool Finished ------ " />
</Target>
</Project>
</Project>
14 changes: 1 addition & 13 deletions CometServer/appsettings.Production.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,7 @@
},
"WriteTo": [
{
"Name": "GrafanaLoki",
"Args": {
"uri": "http://localhost:3100",
"labels": [
{
"key": "app",
"value": "CDP4-COMET WebServices-01"
}
],
"propertiesAsLabels": [
"app"
]
}
"Name": "Console"
}
],
"WriteTo:Async": {
Expand Down
Loading