Repository navigation
[Refactor] centralize shared MSBuild/package settings, require .NET 10 SDK and C# 14 - #83
Merged
samatstariongroup merged 2 commits intoOct 18, 2026
Conversation
…Build.props - move LangVersion into Directory.Build.props and raise it to 14.0 for all projects - move the shared packaging properties, the README/LICENSE/NOTICE pack items and the Microsoft.Sbom.Targets reference into Directory.Build.props, excluding *.Tests projects - keep only per-package settings in ReqIFSharp.csproj and ReqIFSharp.Extensions.csproj Fixes #80 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…targets - move the shared packaging settings, pack items and Microsoft.Sbom.Targets reference into Directory.Build.targets, guarded by '$(IsPackable)' != 'false', replacing the *.Tests project-name check - keep GenerateDocumentationFile in Directory.Build.props (the SDK derives the documentation-file settings before .targets is evaluated); test projects turn it off - add global.json requiring the .NET 10 SDK (rollForward latestFeature) - document the MSBuild layout and SDK requirement in CLAUDE.md - ignore the local agent memory folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samatstariongroup
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
Summary
Settings that both packages repeated now live in one place, and each library
.csprojkeeps only its own settings: target framework, version, title, description, package ID, icon, authors and release notes.Directory.Build.propsDeterministic, languages,LangVersion14.0,GenerateDocumentationFileDirectory.Build.targets(new)'$(IsPackable)' != 'false'): project URL, license, tags,GeneratePackageOnBuild,RequireLicenseAcceptance,IncludeSource/IncludeSymbols,GenerateSBOM,PackageReadmeFile, the README/LICENSE/NOTICE pack items and theMicrosoft.Sbom.Targetsreferenceglobal.json(new)10.0.100,rollForward: latestFeature)Why there are two files
.targets. The test projects setIsPackablein their own project files, which are read afterDirectory.Build.props. OnlyDirectory.Build.targetsis read late enough to check it.GenerateDocumentationFilestays in.props. The SDK works out the documentation file settings before it readsDirectory.Build.targets. When I tried setting it there, the packages lost their XML docs. So the test projects turn it off themselves, next to their existing<IsPackable>false</IsPackable>.Language version and SDK
LangVersiongoes from 12.0 to 14.0 for all projects. That is the version the test projects already used by default onnet10.0.netstandard2.0, so features that need runtime support stay unavailable there: default interface methods, static abstract interface members andreffields.global.jsonnow states. CI already installs10.0.x.Other
CLAUDE.mdgets a short "MSBuild layout" section and a note on the SDK requirement..gitignorenow ignores/.claude/agent-memory-local/.Verification
dotnet build ReqIFSharp.sln -c Release: 0 warnings, 0 errors.dotnet test ReqIFSharp.sln -c Release --no-build: 305 + 84 tests pass.dotnet packpackages compared with those fromdevelopment:.nupkg/.symbols.nupkgcontain the same files.nuspecfiles are identical apart from the commit hashglobal.json, and packable projects are found throughIsPackableinstead of the.Testsname check.🤖 Generated with Claude Code