Repository navigation
Conversation
Codex does not accept a `type` key on [mcp_servers.*] entries; it warns about it and fails under --strict-config. Codex infers the transport from `command`/`url`, and import_from_codex already infers `type` the same way when it is absent, so the field can be dropped from generated TOML without losing round-trip information. Closes SaladDay#496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex rejects a
typekey in[mcp_servers.<id>]tables: it warns, and errors under--strict-config.json_server_to_toml_tablewrote our internaltype(stdio/http/sse) into every generated table.typeto the Codex TOML. It's still used internally to choose the core fields (command/args/env/cwdvsurl/http_headers).import_from_codexalready inferstypewhen it's absent (url→ http, otherwise stdio). Note:ssere-imports ashttp, which matches Codex itself, since it only supports streamable HTTP.Testing
codex_toml_omits_unsupported_type_field(stdio / no type / http / sse → notypekey, correctcommand/url).cargo fmt --check✅cargo test --lib✅ 4567 passed, 0 failed, 2 ignored (after rebase onto currentmain). Note:session_usage_codex::test_incremental_resume_keeps_replay_prefix_alignmentis intermittently flaky locally, independent of this change.import_export_sync/prompt_commands/provider_commandsare pre-existing onmainin my environment (no default editor, official-provider usage template), unchanged by this PR.Closes #496