Repository navigation
Upgrade to Lash 46dfed8ea; remove plan mode - #17
Merged
Merged
Conversation
added 7 commits
September 8, 2026 11:08
Carry process incarnation and event freshness through dock state and selection. Preserve explicit queued-work ownership, handle fallible RLM configuration, retain attachment capability snapshots, and render typed cell failures, advisory issues, omitted records, and charge-refusal evidence. CLI stream IDs restart on reopen, so using them as durable turn or drain identities caused effect replay hash conflicts. Use fresh durable identities while cancellation continues to target the observed TurnStarted ID. Verify catalog refresh leaves pending user input and unrelated work untouched. Release-Notes: Update the Lash runtime pin and adopt its process, capability, and failure-report contracts; prevent replay identity collisions on resume.
Use the same session observer scope for periodic snapshots and post-cancel refreshes. Keep all live rows and limit retired results to PROCESS_RETENTION. The upstream registry still scans observer records before filtering in memory; this bounds returned history and benefits from batched lease reads. Mitigates #15 Release-Notes: Reduce process dock snapshot work while preserving its ten-second retention and observer visibility.
Default to require_guarantee and allow explicit bounded duplicate billing in config.json. Apply the host policy to every shared opener invocation and to the core defaults used for native queued work and child sessions; durable policy serialization cannot preserve this choice. Release-Notes: Configure charge_safety for fresh, cleared, resumed, interactive, and autonomous sessions.
Update session, trace, and remote stamps and derive their test expectations from runtime exports. Explain reset scope, charge safety, retry jitter and Retry-After refusal, and verify refusal without old-home mutation plus charge policy reapplication on fresh and resumed sessions. Release-Notes: Document runtime compatibility and charge policy, with end-to-end reset and retry coverage.
Delete the plan-mode plugin, /plan UI extension, plan dock state and rendering, and feature-specific activity and test coverage. Keep the generic extension seam and process-dock behavior intact. Release-Notes: removed plan mode and the /plan command
Preserve settled rows across differential renders, verify incarnation-scoped process lifecycle and retention, clarify resume aliases, and stop explicitly when frozen quickstart prerequisites are absent. Release-Notes: Correct operator runbook gates and document unavailable quickstart prerequisites.
Keep active-turn targeting unset after dispatch until Lash reports the durable turn identity. This prevents Esc cancellation and current-turn injection from addressing a phantom target during the dispatch window. Release-Notes:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins Lash from
9debf5aabto main46dfed8ea(203 upstream commits) and adopts the range; removes plan mode entirely.Adoption
ObservedProcessincarnation + last-event sequence carried end to end (incarnation-keyed dock identity, so reused process ids cannot inherit an older lifetime's state); typedCellFailurerendering;TurnReport.failure_evidence/omitted/ mandatoryTurnIssueSeverity(advisory issues no longer read as failures); non-exhaustive error fallbacks.--resetdocs updated, with an old-stamp refusal/reset e2e fixture.list_all()ontolist_observed_bywithProcessStatusFilter::Any+retired_since_msderived from the 10s retention window (mitigates Dock snapshot polling scales O(N) with every process the session ever observed #15; residual registry-side scan tracked upstream as FIG-2488). Same observer lens, retention semantics unchanged.charge_safetyconfig key (upstreamSessionPolicy::charge_safetyshape; unset =RequireGuarantee). Live policy, reapplied on every open/reopen path, e2e-covered including reversion on key removal.cli-turn:1), colliding in effect replay on resume. Turns now use Lash-generated identities; a follow-up commit removes the last dispatch-time fabricated seed and adds a mutation-proven regression for the dispatch window (both independent reviews converged on this defect).Plan mode removed
/plan, the plan plugin, plan dock, projector, TUI extension, and all tests/docs references deleted; generic plugin-surface and extension seams retained.Verification
--workspace --all-targets(-D warnings), 347+ workspace tests, 15 CLI e2e, docs checker — all green at head.Review outcome
Two independent reviews (one fresh-context, one high-effort peer) converged on a single blocking defect — the stale dispatch-time
cli-turnseed — fixed in24c3eabwith a regression. All other hard topics (dock lens equivalence, charge-safety defaults/consistency, plan-removal completeness) verified clean. Nits: none blocking.