Skip to content

Tilt-down prompts never ask for the ground in front of the meter #28

Open

Description

@AidenJohnston

Part of the cause of #24. Split out so the guidance can be fixed separately from the "Can't get there" tap.

In field test run 1 (PR #23), "Tilt down to show the ground" asked for the strip 3 ft 3 in, 2 ft 9 in, 4 ft 6 in, 7 ft and 8 ft 9 in right of the meter (0:27–0:46 of the recording). It never asked for the ground in front of the meter, which is the first thing GuidancePlanner.reach needs. Replaying the scan in PR #23 shows the ground 2 ft and 4 ft out by the meter was seen twice only in photos 41–43 of 44.

Why. laggingBand only looks within 1 m of the phone's position along the wall, and it only asks for the ground where the wall is already covered (GuidancePlanner.swift#L141-L155). At the start, beside the meter, the wall wasn't covered yet, so there was no ground prompt. By the time it was covered, the tester had walked on. This is also why the requested distance follows the phone and can go backwards (3 ft 3 in, then 2 ft 9 in).

Possible fixes (your call):

  • ask for the ground in front of the meter right after the close-up, before "Walk slowly to your left";
  • or have laggingBand or firstHole prefer the gap nearest the meter, since reach counts outward from it.

Clip, 0:27–0:46 of the recording:

02-tilt-prompts-skip-ground-at-meter.mp4

Activity

  1. added
    bugSomething is broken or behaving incorrectly.
    size:M30-99 effective changed lines.
    on Sep 26, 2026
  2. self-assigned this
    on Sep 26, 2026
  3. AidenJohnston commented on Sep 26, 2026

    @AidenJohnston
    CollaboratorAuthor

    Addressed in 3c7b83a on t3/ios-mvf (merged in 75dea41).

    What changed

    • GuidancePlanner.preferredTask now asks for the ground in front of the meter (about 1 ft either side of it) before anything except "Take a step back" and the look-past step. It keeps asking until 80% of that ground is covered or skipped. "Can't get there" skips it and the walk moves on.
    • An aim request now keeps its distance while the planner's window drifts by less than 0.3 m. The card shouldn't go from 3 ft 3 in to 2 ft 9 in for the same ground.

    What's left
    Nothing for this issue that I can see. One behaviour to know: this request outranks walking. If you walk off before it's met, the card keeps saying "Tilt down to show the ground, at your meter" until you go back or tap "Can't get there".

    To confirm on the first TestFlight build with 3c7b83a
    After the close-up (and "Take a step back" if you're close), the first walk card should be "Tilt down to show the ground / The strip along the wall, at your meter", before "Walk slowly to your left". Tilt down at the meter from two spots a step apart. The card should clear and move on. Later tilt prompts on the same stretch shouldn't change their distance by a few inches.

  4. AidenJohnston commented on Sep 26, 2026

    @AidenJohnston
    CollaboratorAuthor

    Same in field test run 2 (build 3.1). The tilt-down prompts asked for the strip at 5 ft 3 in, 4 ft 9 in, 4 ft 6 in, 4 ft and 4 ft 3 in right of the meter, and never in front of it or to its left. That's why reach was still 0 on the left at the 0:53 "Can't get there" (#24). The distance also went backwards again, 5 ft 3 in → 4 ft, as in run 1.

  5. AidenJohnston commented on Sep 26, 2026

    @AidenJohnston
    CollaboratorAuthor

    Checked run 2's symptoms against t3/ios-mvf (3c7b83a). Build 3.1 came from e9e405d, which doesn't have 3c7b83a.

    Next field test (a build with #56): the first walk card after the close-up should be "Tilt down to show the ground ... at your meter". Tilt down, take a small step sideways, and check the card moves on. Later tilt prompts should keep their distance while you stay near that spot.

  6. SamGu-NRX commented on Sep 27, 2026

    @SamGu-NRX
    Owner

    Fixed on t3/ios-mvf in 3c7b83a, merged at 75dea41. Build d02cc11 or later for runs 2 and 3; it is green (CI run 36279804539).

    • The walk's first request is now "Tilt down to show the ground" at the meter, before "Walk slowly to your left". It's met once 80% of the ground within 0.3 m of the meter is covered from two positions. "Can't get there" moves on from it.
    • The tilt prompt no longer jumps backwards (3 ft 3 in, then 2 ft 9 in). An unfinished tilt request keeps its stretch while the new one is within 0.3 m of it.
    • Since d0ff1be the walk asks for the wall only up to 4.5 ft, the most a view from the 2 m stand-off shows together with the ground. On the synthetic replay the wall tilt-up prompts along the walk went from 3 to 0. Greater heights, when a check needs them, come as one server-requested view after the upload. That height rests on an assumed field of view of 30° to 31° half angle. If your phone still gets frequent "Tilt up to show more wall" prompts during the walk, please note where in the recording.
  7. AidenJohnston commented on Sep 27, 2026

    @AidenJohnston
    CollaboratorAuthor

    Build 4.1 field test (TestFlight 4.1, beta 45017ba, iPhone 14 without LiDAR, three runs on 2026-09-26): inverted. The ground in front of the meter is now the first thing asked, and until it's met it is the only thing asked, so it blocked the start in all three runs.

    There's no timeout or skip. See #77. Analyses: PR #60 (run 1, run 2, run 3).

  8. added a commit that references this issue on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething is broken or behaving incorrectly.size:M30-99 effective changed lines.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions