Skip to content

Upload screen sits on "Sending measurements, 99%" and skips "Check clearances" #31

Open
Open
Upload screen sits on "Sending measurements, 99%" and skips "Check clearances"#31
Labels
bugSomething is broken or behaving incorrectly.size:S10-29 effective changed lines.

Description

@AidenJohnston
AidenJohnston
opened on Sep 26, 2026

This is U-2 in the field test runbook (PR #23), a known issue that showed up again in run 1. The screen sat on "Sending measurements, 99%" for about 2.2 s, then jumped straight to the result. "Check clearances" was never highlighted. The whole upload took 2.9 s (1:29–1:31 of the recording).

Likely cause. The step moves to .analyzing only when the progress callback reports exactly 1 (ScanEngine.swift#L1346-L1353). The server finds the spot inside that same request. So the body finishes sending (shown as 99% after rounding), and the app waits for the response with the step still on "Sending". The response then sets .analyzing and .done back to back.

Fix. Switch to "Check clearances" as soon as the body has been sent (all bytes sent, not fraction == 1), and keep it highlighted until the response arrives.

Clip, 1:28–1:44 of the recording:

09-upload-and-manual-review-result.mp4

Activity

  1. AidenJohnston
    added
    bugSomething is broken or behaving incorrectly.
    size:S10-29 effective changed lines.
    on Sep 26, 2026

  2. AidenJohnston commented on Sep 26, 2026

    @AidenJohnston
    AidenJohnston
    on Sep 26, 2026
    CollaboratorAuthor

    Seen again in field test run 2 (build 3.1). It shows only on an upload that goes straight to the result:

    • Upload 1 ended on "2 more views to finish" with "Measurements ready", "Measurements sent" and "Clearances checked" all ticked, because that screen holds for followUpHold (ScanEngine.swift#L1353-L1368).
    • Upload 2, after "I can't get there" on the gap request, stayed on "Sending measurements, 99%". "Check clearances" never ticked, and the result appeared about 1.2 s after the tap. .analyzing, then .done, then go(.result) all happen in one turn, and waitForGate returns at once outside autopilot (ScanEngine.swift#L266-L267, ScanEngine.swift#L1353-L1372).
  3. SamGu-NRX
    added a commit that references this issue on Sep 26, 2026

    Merge pull request #34 from SamGu-NRX/t3/run1-quick-fixes

    feb35a0

  4. AidenJohnston commented on Sep 27, 2026

    @AidenJohnston
    AidenJohnston
    on Sep 27, 2026
    CollaboratorAuthor

    Build 4.1 field test (TestFlight 4.1, beta 45017ba, iPhone 14 without LiDAR, three runs on 2026-09-26): still present on the final upload (cosmetic).

    • Run 1, 6:05: "Check clearances" flashed for one frame, then the result.
    • Run 2, 4:32–4:34: "Check clearances" was still spinning when the result appeared.
    • Run 3, 1:45–1:46: the final check also went to the result in about 1 s (not checked frame by frame).

    On first uploads that end on "N more views to finish", every tick shows (run 1, 5:40–5:43). Analyses: PR #60 (run 1, run 2, run 3).

  5. AidenJohnston
    added 2 commits that reference this issue on Sep 27, 2026

    Merge t3/gap-skip-continues (#49) and t3/ios-mvf into t3/41-gap-loop-…

    f23428b

    Merge t3/gap-skip-continues (#49) into t3/41-gap-loop-result

    71509bb
  6. SamGu-NRX
    added a commit that references this issue on Oct 15, 2026

    WS-06 dense geometry, coverage, and scene builder (#31)

    764c046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaving incorrectly.size:S10-29 effective changed lines.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions