You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Marks past the wall's ends are still listed, exported and measured #42
Seen in device field test run 2: TestFlight build 3.1, beta at ad91620, capture code t3/ios-mvfe9e405d, server e106acb. The exported scan was lost before it was copied off the phone, so this comes from the screen recording and the code at ad91620. Times are in the recording. b7f51ba and 49a676e on t3/ios-mvf don't change this.
What happens. The final wall ran from 7 ft 6 in left of the meter to 0 ft 6 in right (see #24 and #35). The feature
list still showed "AC unit / About 16 ft right of your meter" and "Window / About 7 ft right of your meter". The result
measured both:
doors and windows: "Measured 5 ft 11 in. The rule is 3 ft…";
AC: "Measured 15 ft 6 in…".
Run 1 showed the same with the AC stand-in 16 ft past the right end.
Server:parse_scene only checks the wall_id (scene.py#L760-L769). A window without a footprint
becomes a line on the wall's straight extension past the end (scene.py#L713-L740), even when that end
is unexplored and may be a corner.
This is harmless in this run, because the marks were far from the spot. But it tells the homeowner their marks count
when the scan no longer covers them. It also puts objects on a wall line that may not exist.
Possible fixes (your call):
in the app: flag marks outside the ends on the feature list ("past the end of your scan"), or extend the end to
include them;
on the server: say which objects lie past an unexplored end, and don't treat them as on the wall's line.
Server half fixed on t3/server (#11) in 9e42970, live on both hosted servers. An object with no footprint whose span lies past an unexplored end is no longer put on the wall's straight extension, since the wall may turn there. It isn't measured, and the answer names it in a new objects_not_used list (result schema, additive): {object: "objects[3] window", side: "right", message: "The window marked … is past the right end of the scan, where the wall may turn, so it was not used."}. An object across the end keeps its part on the scanned wall. Past a limit end, and for objects with a footprint, nothing changes. The app can show objects_not_used next to its own flag from #53.
Activity
server: fixes from the real-phone run 2 (#44, #45, #42)
SamGu-NRX commentedon Sep 26, 2026
Server half fixed on
t3/server(#11) in 9e42970, live on both hosted servers. An object with nofootprintwhose span lies past anunexploredend is no longer put on the wall's straight extension, since the wall may turn there. It isn't measured, and the answer names it in a newobjects_not_usedlist (result schema, additive):{object: "objects[3] window", side: "right", message: "The window marked … is past the right end of the scan, where the wall may turn, so it was not used."}. An object across the end keeps its part on the scanned wall. Past alimitend, and for objects with a footprint, nothing changes. The app can showobjects_not_usednext to its own flag from #53.Vendor the result schema from t3/server 9e42970
ios: the review flags marks lying past a wall end (#42)
Merge pull request #53 from SamGu-NRX/t3/marks-past-ends
WS-10 result composer and AR guidance (#42)