Skip to content

Clear stale meter-brand suggestions on retake and skip #94

Closed

Description

@SamGu-NRX

Follow-up from PR #89, review comment #89 (comment).

At 916838f, retakeCloseUp, skipCloseUp, and close-up entry clear meterNumber but can retain the prior meterBrand suggestion. Retake followed by skip leaves the old suggestion beside a skipped number. No current scene or packet export consumes it, so this is local state cleanup, not a transmission defect.

Clear the brand alongside the number in the real and demo engines, and add a retake-then-skip assertion. Preserve number candidates when the explicit brand-reject action is used.

The manager explicitly deferred this P3 under the 11:00 CDT convergence rule. It does not block #89 integration once the 6.68 focus threshold, 44-point reject width, and required checks pass.

Activity

  1. SamGu-NRX commented on Sep 27, 2026

    @SamGu-NRX
    OwnerAuthor

    Verified at PR#89 head0a3a05e: meterBrand is only exposed when meterNumber is choose or confirmed, and nil during retake/reading/skipped states. The getter makes the reported stale visible-state case unreachable. Current-head CI passed on attempt2; no separate UI-test gate was added under convergence. Closing as addressed, not as a claim that all close-up lifecycle behavior is verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions