Repository navigation
Ship beta to main: the wall map legend fix and the walk's in-motion audit (#172) - #182
Conversation
…alled Simulator CI run 36307476187 on b90fb8e: testFullFlowFromLidarReplay failed contrast on the walk for a node with no element. Its recording shows the map's legend with three entries (the end preview, hidden sections, Depth-checked) squeezed into one row and laid over each other, and a leaving entry fading over the one taking its place: the walk's controls animation (controlsKey) reached into the map. The legend now takes one row only when every entry fits on a line and stacks otherwise, and its entries change without animating. A new audited state, wallWalk-fullLegend, shows all three at once. testWholeFlowThroughTheButtons missed meter.candidate.0. The picker was never refused: the app's log shows its main thread took no work for 14.6 s while the Simulator's push daemon spun in a reconnect loop, and the close-up script resumed where it stopped. The picker would have come about 17.3 s after the close-up opened, against a 15 s wait; the wait is now 30 s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 1faa79b)
The walk's audit in motion caught real bugs that only show mid-transition: the map legend's entries drawn over each other (1faa79b), the two reply titles half-drawn over each other (b1a2444) and the translucent reply fill (397b6d6). Auditing only the held walk would have hidden them. The walk is now audited on its first appearance as well, report-only: findings are attached as audit-wallWalk-moving and printed, as with HOUSESCAN_AUDIT_REPORT_ONLY, and the strict audit stays on the held walk. Also: LaunchOptions documents <phase>.held, and the LiDAR test's comment no longer times the walk. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 32f6e71)
… a held screen A test audits a held screen only once <phase>.held appears, and the walk's map check after it can wait 90 s; the two-minute gate could expire first on a slow runner and let the app leave mid-audit (Greptile on #169). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ios: beta gets the legend fix and the walk's in-motion audit, report-only
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Note Review skipped Codemetrics is installed on this repository, but it hasn't been added to your team yet. To enable AI code reviews for this repo, go to your dashboard and add house-scanning-master to your team's repositories. |
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Brings
mainup tobetaagain. The only change since #179 is #172:#172's iOS CI passed on
beta. Merge with "Create a merge commit".🤖 Generated with Claude Code