Skip to content

Ship beta to main: the wall map legend fix and the walk's in-motion audit (#172) - #182

Merged
AidenJohnston merged 4 commits into
mainfrom
beta
Sep 27, 2026
Merged

AidenJohnston merged 4 commits into
mainfrom
beta

Conversation

@AidenJohnston

Copy link
Copy Markdown
Collaborator

Brings main up to beta again. The only change since #179 is #172:

#172's iOS CI passed on beta. Merge with "Create a merge commit".

🤖 Generated with Claude Code

SamGu-NRX and others added 4 commits September 27, 2026 08:22
…alled Simulator

CI run 36307476187 on b90fb8e:

testFullFlowFromLidarReplay failed contrast on the walk for a node with
no element. Its recording shows the map's legend with three entries
(the end preview, hidden sections, Depth-checked) squeezed into one row
and laid over each other, and a leaving entry fading over the one taking
its place: the walk's controls animation (controlsKey) reached into the
map. The legend now takes one row only when every entry fits on a line
and stacks otherwise, and its entries change without animating. A new
audited state, wallWalk-fullLegend, shows all three at once.

testWholeFlowThroughTheButtons missed meter.candidate.0. The picker was
never refused: the app's log shows its main thread took no work for
14.6 s while the Simulator's push daemon spun in a reconnect loop, and
the close-up script resumed where it stopped. The picker would have come
about 17.3 s after the close-up opened, against a 15 s wait; the wait is
now 30 s.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 1faa79b)
The walk's audit in motion caught real bugs that only show mid-transition:
the map legend's entries drawn over each other (1faa79b), the two reply
titles half-drawn over each other (b1a2444) and the translucent reply fill
(397b6d6). Auditing only the held walk would have hidden them. The walk is
now audited on its first appearance as well, report-only: findings are
attached as audit-wallWalk-moving and printed, as with
HOUSESCAN_AUDIT_REPORT_ONLY, and the strict audit stays on the held walk.

Also: LaunchOptions documents <phase>.held, and the LiDAR test's comment
no longer times the walk.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 32f6e71)
… a held screen

A test audits a held screen only once <phase>.held appears, and the walk's
map check after it can wait 90 s; the two-minute gate could expire first on
a slow runner and let the app leave mid-audit (Greptile on #169).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ios: beta gets the legend fix and the walk's in-motion audit, report-only
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@codemetrics-ai

Copy link
Copy Markdown

Note

Review skipped

Codemetrics is installed on this repository, but it hasn't been added to your team yet.

To enable AI code reviews for this repo, go to your dashboard and add house-scanning-master to your team's repositories.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2e1d1614-d42b-4c57-ad41-2217eca9eebd

📥 Commits

Reviewing files that changed from the base of the PR and between d9ccaf2 and 42661c3.

📒 Files selected for processing (5)
  • ios/HouseScan/Runtime/LaunchOptions.swift
  • ios/HouseScan/Runtime/ScanEngine.swift
  • ios/HouseScan/UI/Camera/WallTape.swift
  • ios/HouseScanUITests/FullFlowUITests.swift
  • ios/HouseScanUITests/ScreenStatesUITests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines. label Sep 27, 2026
@AidenJohnston
AidenJohnston merged commit ec4e3f6 into main Sep 27, 2026
6 checks passed
@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Fixes wall map legend layout and extends test timeouts.

The PR appears safe to merge, though the new moving-walk audit should retain transient findings to provide its intended diagnostic coverage.

Fix All in Claude CodeFindings

  1. P2 Transient findings go unreported ▶
Fix with agent prompt
### Issue 1
ios/HouseScanUITests/FullFlowUITests.swift:395
The new in-motion audit records only findings seen twice, with a six-second pause between passes. Because the walk replay lasts about six seconds, a contrast issue visible when the walk first appears may be gone by the second pass. It then produces neither an attachment nor an audit log line, leaving the transition-only issues this audit was added to reveal unreported. Please retain first-pass findings for this report-only audit.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary

The PR adjusts the wall-map legend layout, adds a report-only audit during the walk, and lengthens the autopilot gate timeout. The new moving audit can discard the short-lived findings it is meant to surface.

Diagram
sequenceDiagram
  participant Walk
  participant Test
  participant Audit
  Test->>Walk: Wait for wallWalk to appear
  Test->>Audit: First in-motion pass
  Audit-->>Test: Transient finding
  Test->>Test: Wait six seconds
  Walk-->>Test: Replay settles
  Test->>Audit: Second pass
  Audit-->>Test: Finding absent
  Note over Test,Audit: No repeated finding is reported
Loading

Reviews (1) · Last reviewed commit: "Merge pull request #172 from SamGu-NRX/t..."

Comment thread ios/HouseScanUITests/FullFlowUITests.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants