Repository navigation
ios: say why House Scan asks for local network access - #201
Conversation
The developer flow in ios/README.md points the app at a House Scan server on a laptop on the same Wi-Fi. Info.plist already allows plain http to local-network addresses (NSAllowsLocalNetworking), but it had no NSLocalNetworkUsageDescription. iOS asks for local network access in that flow, so the prompt had no purpose text (#144, second half). The new string says the app connects to a House Scan server on the local network only when a developer has set one up for testing. It claims no Wi-Fi scanning. Homeowners use the hosted https server and never reach this. Checked with plutil -lint and a PlistBuddy read-back. Info.plist is hand-maintained (INFOPLIST_FILE in project.yml), so the project file is unchanged. The prompt on a physical phone is not yet checked. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Review skipped Codemetrics is installed on this repository, but it hasn't been added to your team yet. To enable AI code reviews for this repo, go to your dashboard and add BaseScanning to your team's repositories. |
|
Stacked on #191 (
codex/public-assembly-20260930). Addresses the local-network half of #144; the response-binding half is #198.What changed
ios/Config/Info.plistgetsNSLocalNetworkUsageDescription:The developer flow in
ios/README.mdpoints the app at a House Scan server on a laptop on the same Wi-Fi. The plist already allowed plain http to local-network addresses (NSAllowsLocalNetworking), but had no purpose string, so iOS's local network prompt in that flow had no explanation. The text says the app connects only to a developer-configured server and makes no Wi-Fi scanning claim. Homeowners use the hosted https server and never reach this prompt.Verification
plutil -lint ios/Config/Info.plistpasses, and aPlistBuddyread-back returns the string. The diff is the two added lines.Info.plistis hand-maintained (INFOPLIST_FILEinproject.yml), so the generated project is unchanged and signing settings aren't touched.Checklist
🤖 Generated with Claude Code