Skip to content

ios: say why House Scan asks for local network access - #201

Merged
SamGu-NRX merged 1 commit into
codex/public-assembly-20260930from
codex/local-network-purpose
Oct 2, 2026
Merged

SamGu-NRX merged 1 commit into
codex/public-assembly-20260930from
codex/local-network-purpose

Conversation

@SamGu-NRX

Copy link
Copy Markdown
Owner

Stacked on #191 (codex/public-assembly-20260930). Addresses the local-network half of #144; the response-binding half is #198.

What changed

ios/Config/Info.plist gets NSLocalNetworkUsageDescription:

House Scan connects to a House Scan server on your local network only when a developer has set it up for testing.

The developer flow in ios/README.md points the app at a House Scan server on a laptop on the same Wi-Fi. The plist already allowed plain http to local-network addresses (NSAllowsLocalNetworking), but had no purpose string, so iOS's local network prompt in that flow had no explanation. The text says the app connects only to a developer-configured server and makes no Wi-Fi scanning claim. Homeowners use the hosted https server and never reach this prompt.

Verification

  • plutil -lint ios/Config/Info.plist passes, and a PlistBuddy read-back returns the string. The diff is the two added lines.
  • Info.plist is hand-maintained (INFOPLIST_FILE in project.yml), so the generated project is unchanged and signing settings aren't touched.
  • The hosted iOS build on this PR processes the plist.
  • Not checked: the prompt on a physical phone. Nobody has run the laptop-server flow on a device with this build.

Checklist

  • The scope is focused; related changes belong together
  • I explained what changed and why
  • N/A: before/after images. The change is a permission prompt's text, which needs a physical device to show.
  • N/A: video. No motion or interaction changes.

🤖 Generated with Claude Code

The developer flow in ios/README.md points the app at a House Scan server
on a laptop on the same Wi-Fi. Info.plist already allows plain http to
local-network addresses (NSAllowsLocalNetworking), but it had no
NSLocalNetworkUsageDescription. iOS asks for local network access in that
flow, so the prompt had no purpose text (#144, second half).

The new string says the app connects to a House Scan server on the local
network only when a developer has set one up for testing. It claims no
Wi-Fi scanning. Homeowners use the hosted https server and never reach
this.

Checked with plutil -lint and a PlistBuddy read-back. Info.plist is
hand-maintained (INFOPLIST_FILE in project.yml), so the project file is
unchanged. The prompt on a physical phone is not yet checked.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: aa3da419-97c3-4ec1-b07d-4508ea82a314

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines. label Oct 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T19:20:11.902680Z 032eea5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codemetrics-ai

codemetrics-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Note

Review skipped

Codemetrics is installed on this repository, but it hasn't been added to your team yet.

To enable AI code reviews for this repo, go to your dashboard and add BaseScanning to your team's repositories.

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adds a permission prompt explanation for local network access.

The PR appears safe to merge.

Summary

Adds a local-network permission explanation for the documented developer testing flow.

  • The app’s default hosted-server flow does not require local-network access.

Reviews (1) · Last reviewed commit: "ios: say why House Scan asks for local n..."

@SamGu-NRX
SamGu-NRX merged commit db3e9d2 into codex/public-assembly-20260930 Oct 2, 2026
6 checks passed
@SamGu-NRX
SamGu-NRX deleted the codex/local-network-purpose branch October 15, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant