Skip to content

feat(ios): skip automatic follow-ups for an unmeasured wall - #244

Draft
SamGu-NRX wants to merge 1 commit into
alphafrom
feat/d6-unmeasured-wall-followups
Draft

SamGu-NRX wants to merge 1 commit into
alphafrom
feat/d6-unmeasured-wall-followups

Conversation

@SamGu-NRX

@SamGu-NRX SamGu-NRX commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

What changed

Implements DECISIONS D6 option A as recommended; close if you choose otherwise

An answer presented as wall-not-measured now goes straight to the result instead of automatically requesting more capture views. The queue checks the same presentation that hides the proposed spot. A measured wall keeps its existing follow-up queue.

Why

Decision source, #135: someone who already declined both sides should hear that the wall was not measured before being asked to capture more views. This draft implements the recommendation, not a formal product decision.

How it works

automaticGapQueue returns no requests when presentation(of:isSample:) reports wallNotMeasured. The engine regression first checks that a capturable server item produces a queue, records both refused sides, checks that the presentation hides the wall and the queue is empty, then clears the refusals and checks that the queue returns. Removing the guard makes the empty-queue assertion fail.

Verification

On the local verification retry, D7 ran first and the disk guard stopped it after free space fell from 22 GiB below 8 GiB. D6 could not start: df then showed 5.8 GiB, below the 10 GiB start floor. CI Kit, Debug build and photoProcessing have passed; journey UI and screenStates remain pending.

Manual iOS CI run was dispatched on 6483e93906abe8ec4dfbd85c74ac728aef194542 because draft PR events skip the iOS jobs. Kit, app build and UI results are pending.

Local Kit swift test --package-path ios/HouseScanKit --jobs 2 -Xswiftc -warnings-as-errors started with 11.2 GiB free through run-guarded.py --min-free-gib 8 --, but the guard stopped it with exit 75 when free disk fell below 8 GiB. The suite did not complete. App build and UI build-for-testing did not start. CI is the remaining verification; no local build or runtime pass is claimed.

The new EngineGuidanceTests/testAnUnmeasuredWallDoesNotAutomaticallyAskForMoreViews is in the existing journey group. Compilation and runtime execution await CI. Its pre-fix failure was not run locally. No workflow changed.

Risk

Sam has not formally chosen D6. This suppresses automatic follow-ups for the unmeasured-wall presentation; it does not change the server's raw answer or decide D5's refused-walk detection policy.

Checklist

  • Scope is limited to D6 option A and its regression
  • Decision source and recommendation status are explicit
  • UI images/video: N/A, no layout or animation changed; queue behavior awaits CI runtime verification

Implements DECISIONS D6 option A as recommended; close if you choose otherwise.
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines. label Oct 15, 2026
@SamGu-NRX

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T06:35:48.865869Z 6483e93 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 6483e93906

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant