Repository navigation
Conversation
Implements DECISIONS D6 option A as recommended; close if you choose otherwise.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
Implements DECISIONS D6 option A as recommended; close if you choose otherwise
An answer presented as wall-not-measured now goes straight to the result instead of automatically requesting more capture views. The queue checks the same presentation that hides the proposed spot. A measured wall keeps its existing follow-up queue.
Why
Decision source, #135: someone who already declined both sides should hear that the wall was not measured before being asked to capture more views. This draft implements the recommendation, not a formal product decision.
How it works
automaticGapQueuereturns no requests whenpresentation(of:isSample:)reportswallNotMeasured. The engine regression first checks that a capturable server item produces a queue, records both refused sides, checks that the presentation hides the wall and the queue is empty, then clears the refusals and checks that the queue returns. Removing the guard makes the empty-queue assertion fail.Verification
On the local verification retry, D7 ran first and the disk guard stopped it after free space fell from 22 GiB below 8 GiB. D6 could not start:
dfthen showed 5.8 GiB, below the 10 GiB start floor. CI Kit, Debug build and photoProcessing have passed; journey UI and screenStates remain pending.Manual iOS CI run was dispatched on
6483e93906abe8ec4dfbd85c74ac728aef194542because draft PR events skip the iOS jobs. Kit, app build and UI results are pending.Local Kit
swift test --package-path ios/HouseScanKit --jobs 2 -Xswiftc -warnings-as-errorsstarted with 11.2 GiB free throughrun-guarded.py --min-free-gib 8 --, but the guard stopped it with exit 75 when free disk fell below 8 GiB. The suite did not complete. App build and UI build-for-testing did not start. CI is the remaining verification; no local build or runtime pass is claimed.The new
EngineGuidanceTests/testAnUnmeasuredWallDoesNotAutomaticallyAskForMoreViewsis in the existing journey group. Compilation and runtime execution await CI. Its pre-fix failure was not run locally. No workflow changed.Risk
Sam has not formally chosen D6. This suppresses automatic follow-ups for the unmeasured-wall presentation; it does not change the server's raw answer or decide D5's refused-walk detection policy.
Checklist