Skip to content

[obvious-fleet] test(verification): pin unverified-override warning for corner allowance #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamGu-NRX wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

[obvious-fleet] test(verification): pin unverified-override warning for corner allowance #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions verification/tests/test_reported_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,22 @@ def test_public_fingerprint_matches_recorded_public_solver():
assert RULES.rules_sha256 == fixture["result"]["policy"]["rules_sha256"]


@pytest.mark.parametrize(
"assumed",
[
{"battery_width": RULES.width_ft},
{"corner_allowance": RULES.corner_allowance_ft},
],
ids=["battery_width", "corner_allowance"],
)
@pytest.mark.parametrize("identity", ["private source", "different fingerprint"])
def test_unreported_override_is_unverified_even_when_case_matches_public(identity):
def test_unreported_override_is_unverified_even_when_case_matches_public(assumed, identity):
answer = {"policy": {"sources": ["public"], "rules_sha256": RULES.rules_sha256}}
if identity == "private source":
answer["policy"]["sources"].append("private")
else:
answer["policy"]["rules_sha256"] = "f" * 64
warnings = public_assumption_warnings({"battery_width": RULES.width_ft}, answer, RULES)
warnings = public_assumption_warnings(assumed, answer, RULES)
assert len(warnings) == 1
assert "assumed public rules; server may override" in warnings[0]

Expand Down