Skip to content

fix: make eval refusals shape-safe - #311

Merged
SamGu-NRX merged 1 commit into
obv/burst17-bs-review-placement-evalfrom
gpt-burst/1022w2-pr301-eval-refusals
Oct 22, 2026
Merged

SamGu-NRX merged 1 commit into
obv/burst17-bs-review-placement-evalfrom
gpt-burst/1022w2-pr301-eval-refusals

Conversation

@SamGu-NRX

Copy link
Copy Markdown
Owner

Follow-up for #301.

Fixes both remaining review findings:

  • validates parsed produced and committed criteria reports before reading profiles or decidability, turning malformed JSON shapes into a per-row FAIL with suite receipts; and
  • validates sensitivity bands without requiring ground depth, because sensitivity variants are discarded rather than emitted as wire observations.

Added regressions for scalar/list report shapes and ground sensitivity without out_m.

Ruff check/format, compileall, and diff checks pass. Focused pytest is partially blocked by the sparse checkout's missing OpenCV dependency; the scene bridge test command can be rerun with the backend environment.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7b111be9-f924-42e8-b348-21d75122db86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines. label Oct 22, 2026
@SamGu-NRX

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 00cdda9ba2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T16:01:11.561319Z 00cdda9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@SamGu-NRX
SamGu-NRX marked this pull request as ready for review October 22, 2026 16:01
@SamGu-NRX
SamGu-NRX merged commit 212e504 into obv/burst17-bs-review-placement-eval Oct 22, 2026
5 checks passed
@codemetrics-ai

Copy link
Copy Markdown

Note

Review skipped

Codemetrics is installed on this repository, but it hasn't been added to your team yet.

To enable AI code reviews for this repo, go to your dashboard and add BaseScanning to your team's repositories.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; malformed reports become failed rows, and observed ground bands keep their depth requirement.

Summary

The PR makes malformed criteria reports fail their row instead of crashing the suite. It also allows ground sensitivity bands without depth because those bands are never emitted.

  • Malformed criteria reports become clear per-site failures.
  • Ground sensitivity bands can be checked without measured depth.

No actionable issues found. Tests were reviewed but not run.

Reviews (1) · Last reviewed commit: "fix(eval): refuse malformed reports with..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant