Repository navigation
History polish: simpler overview, swipe tip, honest weekly distance - #97
Merged
Merged
Conversation
Remembers on-device which tips the user dismissed, like the pass zoom does for its preference. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Shown until it is dismissed, and false until the stored answer is read so it never flashes for someone who already dismissed it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A week where only some visits have a distance reads 4.2 km logged, since the total undercounts; the row chevrons go, they only covered by the add button. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Drop the this-week line, expand the calendar with a bar across the card, show a dismissible swipe-to-delete tip, and collapse the add button to a plus once the list is scrolled. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A swipe to the left now only asks to delete: the row springs back and a dialog asks for confirmation, so a swipe by mistake changes nothing. The Undo snackbar after a confirmed delete stays. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the History redesign (#96).
What
HintRepository(DataStore, same pattern as the pass zoom) that the History view model reads.Tests
Unit tests for the hint repository (local storage, provider, fake), the view model's tip state, the weekly "logged" totals; screen tests for the tip and the logged label.
./gradlew check ktfmtCheckis green locally. Checked on an emulator;connectedDebugAndroidTestwas not run (the instrumented History test only got the extra constructor argument).Known
The collapsed add button can still sit over the right end of a week header's total while scrolling.
🤖 Generated with Claude Code