Skip to content

ocp: Fix OCP telemetry timestamp field decode #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeff-lien-sndk wants to merge 1 commit into from
Closed

ocp: Fix OCP telemetry timestamp field decode #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/field-parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include <ccan/endian/endian.h>
#include <shared/hex-util.h>
#include <shared/int-util.h>
#include <shared/time-util.h>

#include "cleanup.h"
Expand Down Expand Up @@ -87,10 +88,16 @@ char *process_field_size_8(int offset, char *sfield, __u8 *buf)
datastr = shr_hex_to_ascii(buffer);
} else if (strstr(sfield, "Timestamp")) {
char ts_buf[128];

lval_lo = *((__u64 *)(&buf[offset]));

shr_format_ts(le64_to_cpu(lval_lo), ts_buf);
/*
* TELDF-4 is defined by OCP to hold the NVMe Timestamp
* (Feature Identifier 0Eh) get features structure, not a
* flat 64-bit value; reintrepret it as such rather than
* mask it by hand.
*/
struct nvme_timestamp *ts =
(struct nvme_timestamp *)&buf[offset];

shr_format_ts(int48_to_long(ts->timestamp), ts_buf);
datastr = strdup(ts_buf);
} else {
lval_lo = *((__u64 *)(&buf[offset]));
Expand Down
Loading