Repository navigation
feat!: allow export outside of the screenshot - #662
Merged
RobertMueller2 merged 1 commit intoOct 6, 2026
Merged
Conversation
Collaborator
Author
|
I keep it here for discussion and more testing ... |
Member
|
This not a testing comment yet. Sounds like a decent solution for now. This will inevitably lead to background colouring down the road, you read it here first ;) |
robertwidfen
force-pushed
the
feat/export-crop-outside-image
branch
3 times, most recently
from
September 11, 2026 14:41
a3c4286 to
8302ec8
Compare
Collaborator
Author
|
yeah, but I was glad to realize that femtovg exports transparency which I feel as the most natural background and thus a good default. |
robertwidfen
force-pushed
the
feat/export-crop-outside-image
branch
from
September 11, 2026 17:49
8302ec8 to
dff872f
Compare
robertwidfen
force-pushed
the
feat/export-crop-outside-image
branch
10 times, most recently
from
October 5, 2026 21:05
0b1e463 to
4939e4c
Compare
Closes Satty-org#339 If no crop is defined the exported image will by default include also annotations outside the of the screenshot. To limit it to the screenshot crop to the screenshot. The background of the exported image is transparent so one can put the saved/copied image on top of another background. Maybe in the future we can allow to move annotations (images) behind the screenshot - but for now this is IMHO sufficient.
robertwidfen
force-pushed
the
feat/export-crop-outside-image
branch
from
October 5, 2026 21:33
4939e4c to
52068c5
Compare
robertwidfen
marked this pull request as ready for review
October 5, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339
See also #633, #337
If no crop is defined the exported image will by default include
also annotations outside the of the screenshot. To limit it to
the screenshot crop to the screenshot.
Also wrapping of text to screenshot bounds is removed.
The background of the exported image is transparent so one can put
the saved/copied image on top of another background.
Maybe in the future we can allow to move annotations (images) behind
the screenshot - but for now this is IMHO sufficient.