Repository navigation
test: run the precompile workload testset (and: the Windows julia-1 failure is upstream) - #161
Merged
Conversation
PR #160 appended the "Precompile workload" `@safetestset` after the `return @time @safetestset "Transform Interface"` statement in `core_tests`, so it was unreachable: the regression test for the new `@compile_workload` never ran in any test group. Move the `return` to the last testset so both run. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rmh6B9eoW3N8oCbuuVPVxJ
Wodlfvllf
pushed a commit
to Wodlfvllf/NeuralOperators.jl
that referenced
this pull request
Sep 1, 2026
PR SciML#160 appended the "Precompile workload" `@safetestset` after the `return @time @safetestset "Transform Interface"` statement in `core_tests`, so it was unreachable: the regression test for the new `@compile_workload` never ran in any test group. Move the `return` to the last testset so both run. Claude-Session: https://claude.ai/code/session_01Rmh6B9eoW3N8oCbuuVPVxJ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two separate things were investigated here; only one of them is an actual repo bug.
1. The failing
Core (julia 1, windows-latest)lane is NOT caused by anything in this repoThe lane fails while precompiling Reactant (a
test/Project.tomldependency loaded bytest/shared_testsetup.jl), not while running NeuralOperators code:Evidence that this is an environment/upstream regression rather than a regression from
57cbb6c/eb240e7/1927dfb:julia 1job (run31109559340, commit57cbb6c, 2026-08-06) usedJulia 1.12.6 and Reactant v0.2.278. First red one (run
32005859786, commiteb240e7,2026-08-17) used Julia 1.12.7 and Reactant v0.2.279. Nothing in
eb240e7touchesReactant, precompilation, or the test harness; it only adds a
SciMLTesting = "2.10"compat entry.
(
24043.3 ms ✓ NeuralOperators), including the new@compile_workload. The failure happenslater, inside Reactant's own precompilation.
codex/ci-probe-clean-main-neuraloperatorsprobe (run
31919259681, 2026-08-16, sha4e52d06) is57cbb6cplus a comment-only line inProject.toml— functionally the same tree as the last green run — and itsCore (julia 1, windows-latest)job failed with the identicallld: error: undefined symbol: jl_cstr_to_string, on Julia 1.12.7 with Reactant v0.2.279.Same code, newer toolchain, red.
lld: error: undefined symbolappearsthree times in the same job (Julia's precompile retries) and in every run since 2026-08-16.
julia ltsWindows lane (Julia 1.10) is green at HEAD, matching a Julia-1.12.7-specificcodegen/linker problem.
So the Windows lane should not, by itself, block the release: the released code fails the same
way in the current environment. The fix belongs upstream (Reactant/Julia on Windows).
2. Real bug from #160: the new precompile-workload test never ran
test/runtests.jlgained the"Precompile workload"@safetestsetafterreturn @time @safetestset "Transform Interface" ... end, so it was unreachable — theregression test for the new
@compile_workloadwas dead code in every group. This PR moves thereturnto the last testset.Verification
julia --project=. -e 'using Pkg; Pkg.instantiate(); using NeuralOperators'— the@compile_workloadruns clean (38715.0 ms ✓ NeuralOperatorson Julia 1.11.8, macOS aarch64).julia --project=. -e 'include("test/precompile_workload.jl")'—3 passed, so the newlyreachable testset is green.
Runic --check test/runtests.jl— clean.No version bump here; the release pass handles that.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rmh6B9eoW3N8oCbuuVPVxJ