Repository navigation
build: add solution foundation, quality checks and CI - #1
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
WalterEgo.slnx) with the seven packages (no public API yet), one test project per package, repository architecture tests, a benchmark project and a minimal API sample.latest-Recommendedanalyzers, code style enforced in the build, public API and banned API analyzers, central package management, MinVer versioning, deterministic builds and symbol packages. The SDK is pinned exactly inglobal.json.nuget.configwith package source mapping (nuget.org only), every action pinned to a commit SHA, read-only token by default, Dependabot for NuGet and GitHub Actions, CodeQL (C# and Actions) and OpenSSF Scorecard.dotnet format, package checks, pull request title and internal-reference checks that also run when the pull request is edited, and a check that contract changes come with sample updates.How it was tested
dotnet build -c Release: 0 warnings, 0 errors.dotnet test: 109 passed. The architecture tests cover the solution inventory, build settings, analyzer wiring, the dependency allowlist of each package, internal references in versioned files, the ignored local folder, lock files, NuGet sources, workflows and repository files.dotnet format --verify-no-changes: clean.dotnet pack: 7 packages and 7 symbol packages sharing one prerelease version (0.1.0-alpha.0.4locally).no-sample-impactlabel, and package counts. A locked restore fails with NU1004 when a package version changes without its lock file. Every entry of the banned API list was checked to trigger the analyzer.Public API impact
None: the packages contain no public types yet.