Skip to content

Audit follow-up: correctness, SDK consolidation, and product simplification #4230

Open

Description

@ScriptedAlchemy

Purpose and scope

Track every actionable change from the repository-wide audit and the follow-up Node SDK / napi-rs review. This batch contains 32 new implementation/proposal issues and two existing issues extended or reopened, covering 34 distinct work items. The Work journal ceiling and full-history replay cost share one issue because they need a coherent current-state/history redesign.

Evidence is pinned to 30c23baa1967d4bb04aee3f20deb7a19f302ba61 and revalidated against master at 5daa37d1a3db617238e4503e920cb823a5c28a08. Each issue identifies its source, impact, evidence limits, proposed change, and behavioral acceptance criteria.

The audit used source tracing and isolated Python, Node, SQLite, and OS-pipe probes where stated. It did not run Rust builds or suites because Bazel and rustc were unavailable. Architecture and product proposals are explicitly identified; source counts alone are not evidence of measured non-use, binary size, or runtime cost.

Priorities: 9 P1 items address high-impact correctness or validation failures; 21 P2 items address remaining correctness, architecture, and measurement work; 4 P3 items address product/default-surface simplification. These are review priorities, not measured incident severity.

Recommended execution order

  1. Ship the P1 fixes as focused behavioral changes. Provider cancellation, physical-root ownership, diagnostic fidelity, and run attribution should not wait for a broad rewrite.
  2. Repair evaluation identity, lifecycle, artifact selection, and outcome checks before using the product-wide benchmark to justify scope decisions: Bind hermetic eval results to the exact run and propagate setup/agent failures #4204, Bootstrap an isolated daemon for real-model memory evals and always finalize cleanup #4205, Finish eval and platform build cutover with shipping artifact and dependency patch parity #4206, and Separate verified task outcomes from adoption and routing scores #4216 feed Extend prior outcome evals into product-wide task effectiveness and total-cost baselines #4219.
  3. Co-design the Work current-state/history boundary (Remove Work's 10,000-event write ceiling and full-history replay from current operations #4199) with scope independence (Redesign Work scope selection so unrelated scoped events do not freeze current work #4215). Preserve authorization, durable receipts, version semantics, and restart recovery.
  4. Fix SDK stream semantics (Cancel the TypeScript SDK response body when an operation stream iterator is closed #4209–Recognize unavailable as a terminal operation-stream event in both SDKs #4211), remove the server-adapter dependency (Remove the Rust SDK's server-adapter dependency by relocating shared protocol constants #4224), then migrate the Node implementation through napi-rs (Consolidate the Node SDK onto shared Rust client logic through a thin napi-rs binding #4226). Coordinate HTTP/MCP ownership (Simplify the extension's daemon client boundary across HTTP and MCP operations #4225) without broadening operation admission. The target remains a client of the existing daemon.
  5. Continue the existing native runtime cutover (Finish the native Asupersync runtime cutover #3736) with the added supervision and bounded-wait requirements. Keep its established baseline and behavioral gates.
  6. Implement independent UI/counter/distribution simplifications and evaluate larger Work/default-grammar choices using retained user journeys and measured costs.

Prior work reused

P1 — correctness and evaluation integrity

Runtime and Work design

SDK and daemon-client boundaries

Code intelligence and memory correctness

Dashboard correctness and simplification

Evaluation, distribution, and product scope

Implementation progress — 2026-10-18

  • Cancel the TypeScript SDK response body when an operation stream iterator is closed #4209: PR #4246 merged at 07:17 UTC, merge 0fa6ce80654051fb21fdf0f50054d55f95d02127. The generated extension bundle is committed, and the issue is closed as completed. PR verification records the SDK lifecycle regressions, original-error preservation, 45 SDK tests, typecheck/build and embedded checks; this does not claim the separately excluded installed-package suite ran.
  • Bind hermetic eval results to the exact run and propagate setup/agent failures #4204: PR #4247 merged at 06:56 UTC, merge 82ec8fd92bb530d00acecabad3e1e408c83d5e3d. The issue is closed as completed. Exact session/project identity, actual process exits, duplicate scenario labels, invalid prompts and scorecard identity are covered by the retained read-only hermetic regression workflow.
  • Run the full dashboard typecheck in required CI #4217: PR #4260 adds the full dashboard typecheck plus SDK types/tests, releases frontend checks from the Rust-gate dependency, moves commit lint early, and configures Bazel before first use. In run 39108248835, the new typechecks and SDK tests, existing frontend checks, repository gates and feature gate executed and passed. The later ad5f9577 commit only restores an unrelated Hermes comment; its exact-revision CI must finish before a full-pass claim. No test coverage, timeout or compiler policy was weakened.
  • Delete the unmounted Atlas view from production Code navigation and state #4221: PR #4273 removes Atlas's currently unmounted state and pending-only branches. Old links open Cortex and preserve symbol/scope parameters. Five isolated behavior tests and a strict standalone typecheck of the actual new module passed; full dashboard/Vitest verification remains required.

The two new PRs remain unchecked until merged with the applicable evidence. Other checklist dispositions have not been changed by this update; absence of a checkmark is not a claim that no parallel implementation exists.

Completion

Resolve each linked work item through its stated behavioral acceptance criteria, or record an explicit, evidence-backed decision to defer or decline a proposal. Keep this checklist aligned with those dispositions. Correctness fixes must retain the protected behaviors called out in their issues; migrations should remove their superseded implementations when the production cutover is complete.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions