Skip to content

build(contracts): regenerate for the wal_checkpoint_pinned finding #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Oct 17, 2026
+10 −5
Merged

build(contracts): regenerate for the wal_checkpoint_pinned finding #4177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dashboard/codegen/schemas/dashboard-contracts.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dashboard/src/contracts/decoders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4058,7 +4058,7 @@ The storage family never reports a silent overage: each subclass names one
observable retention/size condition Doctor surfaces over canonical size
observability read models. The set is closed and grows only through a future
versioned enum, never by widening an existing subclass. */
export const DoctorStorageFindingKindV1Schema: z.ZodUnion<[z.ZodLiteral<"over_budget_store">, z.ZodLiteral<"orphan_store">, z.ZodLiteral<"incident_debris_present">, z.ZodLiteral<"retention_backlog">, z.ZodLiteral<"table_growth">, z.ZodLiteral<"pending_schema_migration">]> = z.union([z.literal("over_budget_store"), z.literal("orphan_store"), z.literal("incident_debris_present"), z.literal("retention_backlog"), z.literal("table_growth"), z.literal("pending_schema_migration")]);
export const DoctorStorageFindingKindV1Schema: z.ZodUnion<[z.ZodLiteral<"over_budget_store">, z.ZodLiteral<"orphan_store">, z.ZodLiteral<"incident_debris_present">, z.ZodLiteral<"retention_backlog">, z.ZodLiteral<"table_growth">, z.ZodLiteral<"pending_schema_migration">, z.ZodLiteral<"wal_checkpoint_pinned">]> = z.union([z.literal("over_budget_store"), z.literal("orphan_store"), z.literal("incident_debris_present"), z.literal("retention_backlog"), z.literal("table_growth"), z.literal("pending_schema_migration"), z.literal("wal_checkpoint_pinned")]);

@devin-ai-integration devin-ai-integration Bot Oct 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 WAL checkpoint findings display as unsupported

When wal_checkpoint_pinned reaches the dashboard, storageFindingLabel returns “Unsupported storage finding.” The label map omits this valid kind, hiding its diagnosis across storage and evidence views.

Learn more

The Doctor report uses a typed storage kind for each storage finding. The new variant now passes the dashboard decoder, but storageFindingLabel has no label for it and returns its unsupported fallback. StorageFindingCard and the exact evidence views reuse that label, so a real diagnosis appears unsupported to readers.

Example: A report entry with storage_kind: 'wal_checkpoint_pinned' renders a degraded finding titled “Unsupported storage finding,” rather than “WAL checkpoint pinned.”

Recommended fix: Add a wal_checkpoint_pinned label to FINDING_LABELS and cover the new value in the storage presentation tests.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


export const DuplicateEffectOutcomeV1Schema: z.ZodEnum<{ "committed": "committed"; "not_applicable": "not_applicable"; "prevented": "prevented"; "unknown": "unknown" }> = z.enum(["committed", "not_applicable", "prevented", "unknown"]);

Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/contracts/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ export type DoctorReportEntryV1 = {
storage_kind: DoctorStorageFindingKindV1 | null;
};

export type DoctorStorageFindingKindV1 = "over_budget_store" | "orphan_store" | "incident_debris_present" | "retention_backlog" | "table_growth" | "pending_schema_migration";
export type DoctorStorageFindingKindV1 = "over_budget_store" | "orphan_store" | "incident_debris_present" | "retention_backlog" | "table_growth" | "pending_schema_migration" | "wal_checkpoint_pinned";

@devin-ai-integration devin-ai-integration Bot Oct 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 WAL checkpoint producer disappears from coverage

When Doctor reports wal_checkpoint_pinned, its producer never appears in storage coverage. STORAGE_KINDS still lists six kinds, so producer counts exclude the WAL checkpoint diagnosis.

Learn more

The dashboard's storage findings payload contains both report entries and a per-kind producer status list. with_storage_kind_statuses builds that list from STORAGE_KINDS, which has only the previous six kinds. The new kind reaches the entries, but never gets a source coverage status. StorageSourceStatuses cannot show its producer, and findingsSummary derives its producer count and denominator from that list.

Example: Doctor reports one degraded wal_checkpoint_pinned entry. Its card appears, but the storage producer list still has six rows and no WAL checkpoint row.

Recommended fix: Add WalCheckpointPinned to STORAGE_KINDS and extend the route tests to assert that this new kind appears with the correct source state and observed entry count.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


export type DuplicateEffectOutcomeV1 = "committed" | "not_applicable" | "prevented" | "unknown";

Expand Down
2 changes: 1 addition & 1 deletion plugin/chatgpt-extension/embedded/server.mjs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions sdks/typescript/src/operations.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading