Repository navigation
fix(daemon): list mounted graphs without leasing project servers #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+77
−20
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Evicted graphs remain visible to listings
If eviction removes a project while
mounted_project_graphswaits on its graph slot, the listing can return that retired graph. Background refresh can then select it as a mounted graph and run against a retired project.Learn more
A graph slot remains alive after its server leaves the registry. The listing captures slots, drops the registry lock, and waits for each slot's read lock. A concurrent capacity retirement can remove a server during that wait; its slot still yields the graph, even though the server is no longer mounted. coordinated_background_refresh_writer selects a graph from this listing and sends it into refresh work. A mere snapshot of the graph is not proof that its project remains served.
Example: Project A's slot is write-locked while the listing waits. An open for project B evicts A. When the write lock releases, the listing returns A's graph; background refresh selects A and attempts work on its retired store instead of reporting the retained graph unavailable.
Recommended fix: Tie the listing's returned graphs to registry membership at the point of use, or return a lease that keeps the selected server eligible until consumers finish. Ensure capacity eviction remains possible while the listing is parked; revalidate the selected server's identity before starting refresh or maintenance work.
Was this helpful? React with 👍 or 👎 to provide feedback.