Repository navigation
simplify(dashboard): reuse canonical curation decoders - #4274
Merged
Merged
Conversation
|
ScriptedAlchemy
enabled auto-merge
October 18, 2026 08:03
…/dashboard-curation-decoder
ScriptedAlchemy
disabled auto-merge
October 18, 2026 11:04
ScriptedAlchemy
enabled auto-merge
October 18, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dashboard repeated the automatic-curation binding identity, result schema, canonical hashing and receipt checks beside the TypeScript SDK. Its handwritten envelope schema also accepted responses that the existing canonical SDK decoder rejected.
Changes
Validation
bazel run //sdks/codegen:generatepassed for the follow-up generator source. Generated dashboard application contracts and SDK types were produced from that source.bazel test //dashboard:unit_testfiltered to the curator adapter passed all 29 tests, including concealed 404s, leaked bindings, missing ordinary bindings and inconsistent status/result contracts.bazel test //sdks/typescript:unit_test --test_arg=--maxWorkers=1passed all 46 tests: 42 client tests and 4 stream-disposal tests.git diff --checkpassed; source review completed.Fixes #4192