Repository navigation
fix(mcp): preserve live graph request cancellation - #4333
Open
ScriptedAlchemy wants to merge 1 commit into
Open
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
ScriptedAlchemy
marked this pull request as ready for review
October 18, 2026 21:23
ScriptedAlchemy
enabled auto-merge (squash)
October 18, 2026 21:24
ScriptedAlchemy
disabled auto-merge
October 18, 2026 21:27
ScriptedAlchemy
enabled auto-merge (squash)
October 18, 2026 21:28
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop a cancelled MCP graph request's blocking worker from reading another file after a subsequent ping has acknowledged cancellation.
Motivation
The caller's MCP cancellation signal was relayed asynchronously into a native request token and then into a reconstructed graph signal. A ping could finish before those relays ran, allowing a paused rename-preview worker to resume with an uncancelled replacement signal.
Changes
No wire or persisted contracts change. No LSP source changes are included.
Verification
All checks ran through Bazel on this commit:
Commands used
--remote_download_outputs=allfor these invocations after the initial build encountered missing remote CAS artifacts; no repository cache configuration changed. A full workspace build is not claimed. Focused checks cover the changed daemon-service/composition-root boundary and the reported native LSP behavior.Checklist