Repository navigation
Bootstrap an isolated daemon for real-model memory evals and always clean up - #4355
Draft
ScriptedAlchemy with Copilot wants to merge 2 commits into
Draft
ScriptedAlchemy with Copilot wants to merge 2 commits into
ScriptedAlchemy with Copilot wants to merge 2 commits into
Conversation
|
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daemon initialization for real-model memory evals
Bootstrap an isolated daemon for real-model memory evals and always clean up
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evals/memory/run_real_model.pynow starts its own isolatedtracedecay daemon runfor each scenario and waits for it to be ready beforeinit. Previouslyinitfailed withcode_index_scheduler_unavailableon a fresh profile.report.jsonas error entries instead of callingsys.exit.Motivation
On a fresh isolated profile, the runner called
tracedecay initwith no daemon running.run()then calledsys.exit, which skipped the report. Becausefixturewas only assigned afterbuild_fixture()returned, the fixture directory was also left behind.Changes
EvalEnvironment.start_daemon/stop_daemon):scripts/lib/portable_process.py(exec-session,wait-unix-socket,stop-group), the same helperscripts/with-isolated-tracedecay-daemon.shuses.TRACEDECAY_DAEMON_SOCKETandTRACEDECAY_DATA_DIRpoint at the isolated profile, so the runner cannot reach the operator's daemon or storage.build_fixtureremoves it itself if any setup step fails.seed_fixtureis split out ofbuild_fixture.build_fixturegains an optionalparentargument.run()raises the newEvalSetupErrorinstead of callingsys.exit.run_scenario(), which returns(ok, cancelled).KeyboardInterrupt. A cancelled run writes acancelledreport and exits 130.--agent-turnplus--i-understand-model-cost) is unchanged.evals/memory/README.mddocuments the lifecycle.Test plan
evals/memory/test_run_real_model.pyand pass underpython3 -m unittest(17 tests); I did not run them through Bazel.bazel build //...passes when the change crosses package boundariesThe new tests use a fake
tracedecaybinary and spend no model tokens. They cover:initleaving no fixture directoryNot verified:
tracedecay. Binary resolution is unchanged (target/debug, thenPATH); pinning to the shipping build is tracked separately.cursor-agentturn.Checklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles included