Skip to content

Simplify ordinary settings edits with direct Save - #4362

Draft
ScriptedAlchemy with Copilot wants to merge 16 commits into
masterfrom
copilot/simplify-settings-edits
Draft

ScriptedAlchemy with Copilot wants to merge 16 commits into
masterfrom
copilot/simplify-settings-edits

Conversation

Copilot AI commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace mandatory review and confirmation steps with one editable draft and Save.
  • Preserve revision checks, authorization, and request identity while making uncertain outcomes explicit.

Motivation

Routine settings changes should be straightforward without weakening concurrency or authorization guarantees.

Changes

  • Editor: Remove review/freeze-only transitions and expose direct Save with pending, success, validation, conflict, and permission feedback.
  • Safety: Keep the submitted patch and idempotency key stable. Lost or unverifiable PATCH responses require loading current values before another save.
  • Coverage: Exercise settings writes against the canonical PATCH contract and producer fixture, including DOM journeys and keyboard interaction.

Test plan

  • The affected Bazel targets pass — blocked: Bazel 9.3.0 download failed during DNS resolution
  • bazel build //... passes when the change crosses package boundaries
  • Tested manually (describe below if applicable)
  • Dashboard tests pass (2,130); typecheck and bundle build pass

Checklist

  • CHANGELOG.md updated (under [Unreleased] if no version bump)
  • No secrets, credentials, or .env files included
  • Breaking changes documented (if any)

@changeset-bot

changeset-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1529209

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI and others added 3 commits October 19, 2026 04:08
…ot/simplify-settings-edits

Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor setting edits to simplify workflow Simplify ordinary settings edits with direct Save Oct 19, 2026
Copilot AI requested a review from ScriptedAlchemy October 19, 2026 04:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify ordinary settings edits while preserving revision and authorization guarantees

2 participants