Repository navigation
[Feat] 분석 단계별 진행률 callback 전송 - #48
Merged
dldusgh318 merged 2 commits intoOct 15, 2026
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
boogiewooki02
left a comment
Contributor
There was a problem hiding this comment.
고생하셨습니다!
코드리뷰 확인 부탁드립니다.
Comment on lines
+71
to
+76
| def send_progress(self, analysis_id: int, progress_percent: int) -> None: | ||
| self._post_callback( | ||
| _format_callback_path(self.progress_path, analysis_id), | ||
| AnalysisProgressCallbackPayload(progress_percent=progress_percent), | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
진행률 전송에도 기존 callback의 타임아웃 10초와 재시도 2회 정책이 적용되어, 만약 서버 응답이 없으면 한 번에 약 33초 동안 다음 분석 단계로 넘어가지 못할 수 있어 보입니다. 진행률을 여러 번 전송하는 만큼 대기 시간도 누적될 수 있는데, 진행률 전송에는 타임아웃을 조금 짧게 설정하거나 재시도 횟수를 줄이는 방향을 검토해보면 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #45
🔎 개요
Worker의 분석 단계별 처리율을 Spring에 전달하여 기존 상태 조회 및 FE 폴링에 반영합니다.
📝 작업 내용
👀 변경 사항
POST /api/internal/analyses/{analysisId}/progress,X-Internal-Token,{"progressPercent": 정수}(0–100).SPRING_PROGRESS_CALLBACK_PATH기본값은 위 경로입니다. 기존 timeout 10초, 최대 재시도 2회 설정을 재사용합니다.📸 스크린샷 (Optional)
✅ 체크리스트
venv/bin/python -m unittest discover -s tests: 70개 통과.git diff --check: 통과. 테스트 로그는 저장소 외부 임시 경로에만 저장했습니다.💬 고민사항 및 리뷰 요구사항 (Optional)