Repository navigation
Expose JPH::ShapeFilter::mBodyID2 to C via JPC_ShapeFilter_getBodyID2 - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And pass a ShapeFilter pointer to the ShapeFilterFns to get at the ShapeFilter form inside the ShapeFilterFns
The motivation for implementing it this way instead of simply passing the body ID into ShapeFilterFns is that the C API should support creating a ShapeFilter with
JPC_ShapeFilter_newand read the body from it independently of the ShapeFilterFns. Also if JPH::ShapeFilter has members added in the future this won't bloat the ShapeFilterFns signatures.instead of
because the
OPAQUE_WRAPPER(JPC_ShapeFilter, JPC_ShapeFilterBridge)is invoked after the JPC_ShapeFilterBridge definition so we can't use it.