Conversation
Katze719
marked this pull request as draft
September 1, 2026 18:55
Mqxx
reviewed
Sep 1, 2026
| * @param error_callback Optional error callback. | ||
| * @return 0 on success or a negative StatusCode value. | ||
| */ | ||
| MODULE_API auto serialApplyConfig(int64_t handle, const cpp_core::SerialPortConfig *config, |
Member
There was a problem hiding this comment.
Suggested change
| MODULE_API auto serialApplyConfig(int64_t handle, const cpp_core::SerialPortConfig *config, | |
| MODULE_API auto serialSetPortConfig(int64_t handle, const cpp_core::SerialPortConfig *config, |
Mqxx
reviewed
Sep 1, 2026
| * @param error_callback Optional error callback. | ||
| * @return 0 on success or a negative StatusCode value. | ||
| */ | ||
| MODULE_API auto serialGetConfig(int64_t handle, cpp_core::SerialPortConfig *config, |
Member
There was a problem hiding this comment.
Suggested change
| MODULE_API auto serialGetConfig(int64_t handle, cpp_core::SerialPortConfig *config, | |
| MODULE_API auto serialGetPortConfig(int64_t handle, cpp_core::SerialPortConfig *config, |
Mqxx
reviewed
Sep 1, 2026
| * @param error_callback Optional error callback. | ||
| * @return 0 on success or a negative StatusCode value. | ||
| */ | ||
| MODULE_API auto serialPortListGet(int64_t list_handle, int index, cpp_core::SerialPortInfo *port_info, |
Member
There was a problem hiding this comment.
Suggested change
| MODULE_API auto serialPortListGet(int64_t list_handle, int index, cpp_core::SerialPortInfo *port_info, | |
| MODULE_API auto serialGetPortList(int64_t list_handle, int index, cpp_core::SerialPortInfo *port_info, |
Katze719
force-pushed
the
feat/serial-helpers
branch
from
September 2, 2026 07:10
2bd6714 to
a0fe1c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few serial helpers and deprecates the old variants.