Skip to content

Fix time exceeded for re-runs#141

Open
katstankiewicz wants to merge 5 commits into
mainfrom
fix-time-exceeded-for-re-runs
Open

Fix time exceeded for re-runs#141
katstankiewicz wants to merge 5 commits into
mainfrom
fix-time-exceeded-for-re-runs

Conversation

@katstankiewicz

Copy link
Copy Markdown
Collaborator
  • Allow time-exceeded runs to skip the conversation valid end gate when re-running (this happens in the validate_existing flow)
  • Save _conversation_stats immediately if timeout is hit (otherwise they were being saved as 0)

Comment thread src/eva/orchestrator/validation_runner.py Outdated
if gate_passed:
# Run LLM metrics on gate-passed and time-limit records together.
# gate_passed records get GATE_METRIC=1.0 in their scores; time-limit records do not.
all_llm_ids = gate_passed + time_limit_ids

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a name like ids_to_judge would be clearer? I was confused with what all_llm_ids meant at first. Same for all_llm_contexts

@gabegma gabegma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

katstankiewicz and others added 2 commits June 15, 2026 16:05
Co-authored-by: Gabrielle Gauthier-Melancon <gabrielle.gm@servicenow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants