feat(zeronym): record the diverted migration's txid in the shim log - #32
Open
judah-caruso wants to merge 1 commit into
Open
feat(zeronym): record the diverted migration's txid in the shim log#32judah-caruso wants to merge 1 commit into
judah-caruso wants to merge 1 commit into
Conversation
The divert path logged only whether the hub accepted the transaction, which is enough to know something was diverted but not enough to line a shim log up against the hub's own record when an operator is chasing a stuck migration. Correlating the two currently means matching on timestamps alone. The hub's SendResponse already carries the txid in `error_message` on success, so the value is in hand at the point of logging and needs no extra call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Found 1 test failure on Blacksmith runners: Failure
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Collaborator
Author
|
For human eyes only This is a test PR to see how good our little robot friend is at reviewing code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The divert path currently logs only whether the hub accepted the transaction. That tells you a migration went through, but not which one, so lining a shim log up against the hub's own record while chasing a stuck migration comes down to matching timestamps.
The hub's
SendResponsealready carries the txid inerror_messageon the success arms, so the value is already in hand where the log line is emitted — no extra call, no extra state.Field name is
txidto match what the hub logs on its side.