Skip to content

chore(vscode-extension): add webpack size budget to catch bundle regressions #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EvilGenius13 wants to merge 1 commit into
base: jf/vscode-extension-bundle-size
Choose a base branch
from
Draft

chore(vscode-extension): add webpack size budget to catch bundle regressions #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion packages/vscode-extension/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,26 @@ const baseConfig = {
},
}

/**
* @param {WebpackConfig | (() => Promise<WebpackConfig>)} config
* @param {number} maxBytes
* @returns {(env: any, argv: any) => Promise<WebpackConfig>}
*/
function withBudget(config, maxBytes) {
return async (_env, argv) => {
const resolved = typeof config === 'function' ? await config() : config;
if (argv?.mode !== 'production') return resolved;
return {
...resolved,
performance: {
hints: 'error',
maxAssetSize: maxBytes,
maxEntrypointSize: maxBytes,
},
};
};
}

/** @type WebpackConfig */
const desktopConfig = {
...baseConfig,
Expand Down Expand Up @@ -175,4 +195,8 @@ const browserServerConfig = async () => {
};
};

module.exports = [desktopConfig, browserClientConfig, browserServerConfig];
module.exports = [
withBudget(desktopConfig, 8_000_000),
withBudget(browserClientConfig, 2_600_000),
withBudget(browserServerConfig, 8_000_000),
];
Loading