Fix local block validation in presets and defaults - #1285
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965
What changed
default.blocksRoot cause
ValidBlockTargetreturned as soon as it found a local block declaration, so preset and default references were never checked. In addition, ordinary default block entries were omitted from the collected default-level blocks unless they happened to have anameproperty.The check now compares top-level preset and default block types with the section's local declarations before returning. Theme-block validation remains on its existing path.
Tests
ValidBlockTargetsuite: 73 passedtheme-check-commonsource suite: 4,855 passedtsc -b packages/theme-check-common/tsconfig.build.jsontsc -p packages/theme-check-common/tsconfig.json --noEmitpnpm format:checkgit diff --check