Repository navigation
Run dotnet format whitespace so the pre-commit check passes - #173
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit check (dotnet format whitespace, .NET 8, same as CI) was failing on greenfield for every PR, including docs-only ones.
This runs the same hook over the repo. It changes whitespace only in 252 C# files: brace placement and indentation. Verified by comparing every changed file with all whitespace stripped, before and after, and they match. No line-ending changes, and no non-C# files touched.
Heads-up: draft #168 edits BuilderWindow.cs and SqEditorAppApi.cs, which this also reformats, so it will need a rebase. Running
dotnet format whitespace --folderon that branch before rebasing resolves it.