Update version script to work with generic tags. - #117
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SimpleITK R package helper script to only treat versioned release tags as “tags” for version derivation, and to treat non-version tags (e.g., latest) as generic committish targets.
Changes:
- Restrict exact-tag detection to
v-prefixed numeric tags viagit describe --exact-match --match 'v[0-9]*'. - Restrict “future tag” (
--contains) and nearest-ancestor tag lookups to the same release-tag pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+57
| # Matches tags with a v prefix (v3.0.0, v3.0.0a1). | ||
| # Tags without a leading 'v' fall through to the ancestor-search branch below. |
Collaborator
There was a problem hiding this comment.
nope, all tags start with v, followed with version and so on ...
Release tags are preceeded with a 'v', other committish worked using the fallback. The lightweight "latest" tag was identified as a tag but should have gone via the committish code path. Now we treat all tags that are not preceeded by a 'v' as a generic committish.
zivy
force-pushed
the
updateVersionScript
branch
from
August 6, 2026 14:49
28428a0 to
d52b8b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tags are preceeded with a 'v', other
committish worked using the fallback. The
lightweight "latest" tag was identified as a
tag but should have gone via the committish code
path. Now we treat all tags that are
not preceeded by a 'v' as a generic committish.