Repository navigation
fix(island): the robot stays in the island - #56
Merged
Merged
Conversation
A drag on the pill's robot or the deck's character no longer sets it loose on the desktop: it carries the island like the rest of the pill. Only Settings > Place puts the robots on the desktop (robotsPicked); a robot pulled out by a drag before goes back into the island on launch.
An app that draws its own title bar, as Boite does, covers the whole screen when maximized. The companion took it for a game in full screen and stayed hidden, Settings from the tray included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The robot no longer comes out of the island by accident.
Why
Since v0.1.19, a still press of 400 ms on a robot-only pill, then a drag, pulled the robot out onto the desktop. Users who pause before dragging set it loose without meaning to. Loose, the island is gone and the desktop companion shows instead, so the app looks like an older version.
What changes
lib/island/hold.svelte.tsremoved).robotsPicked.robots: "desktop"but norobotsPickedcame from a drag: they read as the island, so the island is back on the next launch.Checks
bun run check: 0 errors, 0 warnings.vitest: 76 files, 550 tests. New: the prefs migration, a drag on the deck's character.cargo test: 93 passed; clippy clean. New page test: Settings opens over loose robots and puts them back in the island.