Skip to content

Fix logging - #27

Open
wiviw5 wants to merge 3 commits into
SkyBlock-Central:mainfrom
wiviw5:fix-logging
Open

Fix logging#27
wiviw5 wants to merge 3 commits into
SkyBlock-Central:mainfrom
wiviw5:fix-logging

Conversation

@wiviw5

@wiviw5 wiviw5 commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Pretty sure I got all the instances of logging all added onto one static method I made within the main class.

Migrating it so that way logging to debug is simplified and unified instead of having different formatting for every case we want to debug log something.

wiviw5 added 2 commits June 5, 2023 13:19
CraftedFury
CraftedFury previously approved these changes Jun 7, 2023
Ascynx
Ascynx previously approved these changes Jun 24, 2023
@Ascynx
Ascynx dismissed stale reviews from CraftedFury and themself via 216037d June 24, 2023 13:10
@Ascynx
Ascynx requested a review from CraftedFury June 24, 2023 13:11
Ascynx
Ascynx previously approved these changes Jun 24, 2023
@wiviw5
wiviw5 dismissed Ascynx’s stale review June 24, 2023 13:11

The merge-base changed after approval.

Harry282
Harry282 previously approved these changes Jun 24, 2023
@wiviw5
wiviw5 dismissed Harry282’s stale review June 24, 2023 13:38

The merge-base changed after approval.

@Ascynx

Ascynx commented Jun 24, 2023

Copy link
Copy Markdown
Member

image
doesn't look like it changed to me tho?

Ascynx
Ascynx previously approved these changes Jun 24, 2023

@Ascynx Ascynx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will not stop me >:(

@wiviw5
wiviw5 dismissed Ascynx’s stale review June 24, 2023 17:31

The merge-base changed after approval.

Ascynx
Ascynx previously approved these changes Jun 24, 2023
@wiviw5
wiviw5 dismissed Ascynx’s stale review June 24, 2023 18:06

The merge-base changed after approval.

@Ascynx Ascynx closed this Jun 24, 2023
@Ascynx Ascynx reopened this Jun 24, 2023

@Ascynx Ascynx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this again

@Ascynx
Ascynx requested a review from Harry282 June 24, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants