Better hud - #2377
Conversation
note: if this were to be reverted, parents weren't set.
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/PlayerListWidget.java
actually have no idea why this line got added
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/EssenceWidget.java
kevinthegreat1
left a comment
There was a problem hiding this comment.
I would suggest a lot more comments. For example, things like TabHudWidget is widgets from the tab, not related to whether it is being shown on the fancy tab layer or fancy hud layer. Also, document how the new config works, etc.
In addition to code review:
- The open widget config screen button in skyblocker config doesn't work.
- Removing a widget with the delete key doesn't seem to work
- Missing a few textures
- The "Auto Screen Anchor" tooltip is quite useless, maybe explain what it does in the tooltip?
- None of the tab hud widgets seem to be showing up on any island? See attached screenshot, I'm expecting a lot of default tab widgets there, but there are none. (This is my first time running the pr.) If this is intended, due to me editing a different island than the one I'm on (which is unknown) then there should be at least some placeholders based on what widgets are expected there, or what widgets are configured. Or perhaps the widgets config really should be connected with the hypixel
/widgets?
|
I do think this is a lot more intuitive though, so thanks! |
Well first fancy tab needs to be enabled duh. Making it connected to the hypixel
Advantages:
So uuuhh maybe I guess 🤷 Other issues in the "main review message" should be easy to fix and are due to oversights and voodoo magic (the description of the auto screen anchor button IS there, just... with the wrong translation key somehow, and i was 99% sure i committed the textures lol) |
AzureAaron
left a comment
There was a problem hiding this comment.
Just some small fixes left otherwise it looks good
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPlayerWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPlayerWidget.java
* start breaking everything * continue * idk * it works pretty well i think * fix mutability oversights * fix positions not updating properly when switching layer * remove inheritance shenanigans note: if this were to be reverted, parents weren't set. * replace ScreenId with plain old Location * isWidgetInCurrentScreen * prevent moving things from tab * copy everywhere button * fancy tab shenanigans * fix weird dropdown stuff actually have no idea why this line got added * ElementBasedWidget config shenanigans * widget removal changes * better copying * detail issues * GlobalOptionsScreen fix * change help text * fix some small oversights * missing tab widget message * update PlayerListManager when tab updates * spotless grrr * experimental layer editing stuff * fix election widget * finish implementing WidgetsListScreen I swear I finished it a bit back but apparently not * rename option back to tabHudEnabled to avoid breaking old configs * rename Layer to EditableLayer * add a few comments * don't override /widgets anymore :( * probably fix that lasso issue alex had * removed a line I shouldn't have by accident * bring back config buttons for now * DFU * spotless * some comments * move Positioner to upper level * remove FancyTab field from LayerConfig * event widget fix * 26.2 and merge problems * requested changes * rename GlobalOptionsScreen to OtherOptionsScreen and change layout a bit * fix tab widgets not being in the correct order * fix top bar showing the wrong location sometimes * Refactor hud data fixer * Fix a few hud ids * Clean up hud fixer * Add reset all text * Add more help text * Add location warning * Fix nullability warnings * fix the data fixing * spotless kevin's changes * Add select prompt tooltip * Use replace field * container utils stuff and merge oopsies * Remove widget type rendering and move hypixel widget warning to bottom * Fix dungeons * Apply spotless * Fix compile * Fix merge issues * Fix foraging * requested changes --------- Co-authored-by: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com> (cherry picked from commit 3c8f124)
hey it's that thing again.
This PR hopefully makes the hud system less confusing. hopefully.
not everything is done to hopefully ease merge conflicts and would be done at a later date.
misssing:
instanceofchecks for config stuffA quick run through of changes I guess:
ScreenBuilderinstances, only one whose config is changed/widgetsis decoupled from the config screen and has its own option for the fancy stuffI would appreciate some thoughts on the comment at the top of LayerBuilder