Skip to content

Better hud - #2377

Merged
kevinthegreat1 merged 75 commits into
SkyblockerMod:mainfrom
viciscat:better-hud
Aug 18, 2026
Merged

Better hud#2377
kevinthegreat1 merged 75 commits into
SkyblockerMod:mainfrom
viciscat:better-hud

Conversation

@viciscat

@viciscat viciscat commented May 8, 2026

Copy link
Copy Markdown
Collaborator

hey it's that thing again.
This PR hopefully makes the hud system less confusing. hopefully.
not everything is done to hopefully ease merge conflicts and would be done at a later date.
misssing:

  • removing the instanceof checks for config stuff
  • move widget options from the normal config to the widgets thingamajig
  • some other stuff I probably forgot

A quick run through of changes I guess:

  • no more multiple ScreenBuilder instances, only one whose config is changed
  • /widgets is decoupled from the config screen and has its own option for the fancy stuff
  • new config screen, where you right click to add widgets and stuff

I would appreciate some thoughts on the comment at the top of LayerBuilder

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 8, 2026
@AzureAaron AzureAaron added this to the 6.6.0 milestone May 12, 2026

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a lot more comments. For example, things like TabHudWidget is widgets from the tab, not related to whether it is being shown on the fancy tab layer or fancy hud layer. Also, document how the new config works, etc.

In addition to code review:

  • The open widget config screen button in skyblocker config doesn't work.
  • Removing a widget with the delete key doesn't seem to work
  • Missing a few textures
  • The "Auto Screen Anchor" tooltip is quite useless, maybe explain what it does in the tooltip?
  • None of the tab hud widgets seem to be showing up on any island? See attached screenshot, I'm expecting a lot of default tab widgets there, but there are none. (This is my first time running the pr.) If this is intended, due to me editing a different island than the one I'm on (which is unknown) then there should be at least some placeholders based on what widgets are expected there, or what widgets are configured. Or perhaps the widgets config really should be connected with the hypixel /widgets?
Image

Comment thread src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java Outdated
Comment thread src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java Outdated
Comment thread src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/ConfigScreenBuilder.java Outdated
Comment thread src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/LayerBuilder.java Outdated
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Jun 4, 2026
@kevinthegreat1

Copy link
Copy Markdown
Collaborator

I do think this is a lot more intuitive though, so thanks!

@viciscat

viciscat commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

None of the tab hud widgets seem to be showing up on any island? See attached screenshot, I'm expecting a lot of default tab widgets there, but there are none. (This is my first time running the pr.) If this is intended, due to me editing a different island than the one I'm on (which is unknown) then there should be at least some placeholders based on what widgets are expected there, or what widgets are configured. Or perhaps the widgets config really should be connected with the hypixel /widgets?

Well first fancy tab needs to be enabled duh.
It takes the where-you-are-standing island's widgets. So if you are in the HUB, and you are editing the Garden's widgets, then it's gonna show the HUB's tab widgets. And since there's no tab in unknown, there's nothing showing up.
We could do a little list of expected widgets to show if you are editing another island than your current one, based on the hypixel default probably.

Making it connected to the hypixel /widgets again would have advantages and disadvantages:
Disadvantages:

  • Need inventory interaction, dropdown would have to go back to the previous menu, and selecting something would have to click on the correct slot. Doable I suppose, but more spaghetti code probably
  • Less responsive buttons on high ping

Advantages:

  • Correct tab
  • Directly editing the hypixel settings on the side panel thing for tab widgets
  • Maybe more, like ordering the tab

So uuuhh maybe I guess 🤷

Other issues in the "main review message" should be easy to fix and are due to oversights and voodoo magic (the description of the auto screen anchor button IS there, just... with the wrong translation key somehow, and i was 99% sure i committed the textures lol)

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge merge conflicts This PR has merge conflicts that need solving. and removed merge me please Pull requests that are ready to merge labels Jul 27, 2026
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Aug 15, 2026
kevinthegreat1
kevinthegreat1 previously approved these changes Aug 15, 2026
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 15, 2026

@AzureAaron AzureAaron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small fixes left otherwise it looks good

Comment thread src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/TopBarWidget.java Outdated
Comment thread src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java Outdated
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed merge me please Pull requests that are ready to merge labels Aug 17, 2026
# Conflicts:
#	src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPlayerWidget.java
# Conflicts:
#	src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPlayerWidget.java
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed merge conflicts This PR has merge conflicts that need solving. labels Aug 18, 2026
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Aug 18, 2026
@kevinthegreat1
kevinthegreat1 merged commit 3c8f124 into SkyblockerMod:main Aug 18, 2026
3 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 18, 2026
Alex33856 pushed a commit that referenced this pull request Aug 19, 2026
* start breaking everything

* continue

* idk

* it works pretty well i think

* fix mutability oversights

* fix positions not updating properly when switching layer

* remove inheritance shenanigans
note: if this were to be reverted, parents weren't set.

* replace ScreenId with plain old Location

* isWidgetInCurrentScreen

* prevent moving things from tab

* copy everywhere button

* fancy tab shenanigans

* fix weird dropdown stuff

actually have no idea why this line got added

* ElementBasedWidget config shenanigans

* widget removal changes

* better copying

* detail issues

* GlobalOptionsScreen fix

* change help text

* fix some small oversights

* missing tab widget message

* update PlayerListManager when tab updates

* spotless grrr

* experimental layer editing stuff

* fix election widget

* finish implementing WidgetsListScreen
I swear I finished it a bit back but apparently not

* rename option back to tabHudEnabled to avoid breaking old configs

* rename Layer to EditableLayer

* add a few comments

* don't override /widgets anymore :(

* probably fix that lasso issue alex had

* removed a line I shouldn't have by accident

* bring back config buttons for now

* DFU

* spotless

* some comments

* move Positioner to upper level

* remove FancyTab field from LayerConfig

* event widget fix

* 26.2 and merge problems

* requested changes

* rename GlobalOptionsScreen to OtherOptionsScreen and change layout a bit

* fix tab widgets not being in the correct order

* fix top bar showing the wrong location sometimes

* Refactor hud data fixer

* Fix a few hud ids

* Clean up hud fixer

* Add reset all text

* Add more help text

* Add location warning

* Fix nullability warnings

* fix the data fixing

* spotless kevin's changes

* Add select prompt tooltip

* Use replace field

* container utils stuff and merge oopsies

* Remove widget type rendering and move hypixel widget warning to bottom

* Fix dungeons

* Apply spotless

* Fix compile

* Fix merge issues

* Fix foraging

* requested changes

---------

Co-authored-by: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com>

(cherry picked from commit 3c8f124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants