Skip to content

chore: upload PR 10652 visual evidence - #2

Closed
Skymore wants to merge 1 commit into
mainfrom
assets/pr10652-attachment-upload
Closed

Skymore wants to merge 1 commit into
mainfrom
assets/pr10652-attachment-upload

Conversation

@Skymore

@Skymore Skymore commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Temporary attachment host for upstream PR kirodotdev#10652.

Before: multi-line descriptions, ambiguous Auto Default subtitle, disabled effort slider

After: shadcn popover, compact model rows, effective effort title, clickable Default marker

before-after-with-explanations.webm

@Skymore

Skymore commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

Attachments were uploaded for upstream kirodotdev#10652 and are now referenced there. Closing this temporary host PR.

@Skymore Skymore closed this Sep 14, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running labels Sep 14, 2026
@github-actions

Copy link
Copy Markdown

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for b6cf51b9ac37c101590fd7a2b8e09a46c6e6c7d9; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b6cf51b9ac37c101590fd7a2b8e09a46c6e6c7d9: <one-sentence reason>

Skymore pushed a commit that referenced this pull request Sep 26, 2026
…dotdev#13779) (kirodotdev#13978)

While a turn ran, ChatFooter's plain running state rendered ONLY the
decorative mascot carousel — `<img>` ghost poses with alt="" and
aria-hidden="true". When those images did not paint (as they did not in
the nightly GUI user test), a first-time user was left staring at a short
column of broken-image glyphs with no text, unsure whether the assistant
was working or broken; assistive tech got nothing to announce either. The
stopping and compacting branches already render localized text beside their
icon — the plain running branch was the only in-progress state with no
readable fallback.

Add a visible, localized "Thinking…" label beside the running-state artwork
and wrap the row as role="status" with that label as its accessible name.
The label reads the same as the sidebar row and the side-chat indicator
(pages.chat.chatFooter.thinking reuses the established sideChat wording per
locale), and matches how stopping/compacting present, so the indicator is
never a bare glyph row and is announced to screen readers. The mascot
carousel is unchanged — it stays for every user where the poses render; the
text is an additional, always-readable fallback, and it survives even when a
throwing theme loader fails closed to nothing under the ErrorBoundary. No
emoji or text glyph is used as the spinner (that would reintroduce the
missing-glyph class of bug).

Diagnosis: the robust root cause is the absent text/accessible fallback in
the running state (candidate #2). The pose SVGs are Vite-inlined data URIs
served with the bundle (all < 4KB, so no separate asset request and no 404
path), and they render correctly in an ordinary browser — the capture
harness here shows them painting beside the label — so the GUI-test glyphs
were an environment-specific render failure, not a bundling/path bug. The
correct fix is therefore the always-present readable label, not a change to
asset loading.

- New key pages.chat.chatFooter.thinking added to every shipping locale
  catalog with a real translation; en-XA regenerated via
  scripts/gen-pseudolocale.mjs.
- Component tests pin that the running footer exposes a readable, localized,
  accessible indicator (role=status named "Thinking…"), keeps the carousel,
  and still shows the label when the theme artwork fails closed.
- Screenshot harness scripts/capture-chat-waiting-indicator.mjs captures the
  running footer in English and Chinese (temp-screenshots/chat-waiting-indicator).

Closes kirodotdev#13779

Co-authored-by: Gary Jennings <gjjnn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant