Repository navigation
Conversation
Owner
Author
|
Attachments were uploaded for upstream kirodotdev#10652 and are now referenced there. Closing this temporary host PR. |
GPT 5.6 Review —
|
Skymore
pushed a commit
that referenced
this pull request
Sep 26, 2026
…dotdev#13779) (kirodotdev#13978) While a turn ran, ChatFooter's plain running state rendered ONLY the decorative mascot carousel — `<img>` ghost poses with alt="" and aria-hidden="true". When those images did not paint (as they did not in the nightly GUI user test), a first-time user was left staring at a short column of broken-image glyphs with no text, unsure whether the assistant was working or broken; assistive tech got nothing to announce either. The stopping and compacting branches already render localized text beside their icon — the plain running branch was the only in-progress state with no readable fallback. Add a visible, localized "Thinking…" label beside the running-state artwork and wrap the row as role="status" with that label as its accessible name. The label reads the same as the sidebar row and the side-chat indicator (pages.chat.chatFooter.thinking reuses the established sideChat wording per locale), and matches how stopping/compacting present, so the indicator is never a bare glyph row and is announced to screen readers. The mascot carousel is unchanged — it stays for every user where the poses render; the text is an additional, always-readable fallback, and it survives even when a throwing theme loader fails closed to nothing under the ErrorBoundary. No emoji or text glyph is used as the spinner (that would reintroduce the missing-glyph class of bug). Diagnosis: the robust root cause is the absent text/accessible fallback in the running state (candidate #2). The pose SVGs are Vite-inlined data URIs served with the bundle (all < 4KB, so no separate asset request and no 404 path), and they render correctly in an ordinary browser — the capture harness here shows them painting beside the label — so the GUI-test glyphs were an environment-specific render failure, not a bundling/path bug. The correct fix is therefore the always-present readable label, not a change to asset loading. - New key pages.chat.chatFooter.thinking added to every shipping locale catalog with a real translation; en-XA regenerated via scripts/gen-pseudolocale.mjs. - Component tests pin that the running footer exposes a readable, localized, accessible indicator (role=status named "Thinking…"), keeps the carousel, and still shows the label when the theme artwork fails closed. - Screenshot harness scripts/capture-chat-waiting-indicator.mjs captures the running footer in English and Chinese (temp-screenshots/chat-waiting-indicator). Closes kirodotdev#13779 Co-authored-by: Gary Jennings <gjjnn@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary attachment host for upstream PR kirodotdev#10652.
before-after-with-explanations.webm