Skip to content

Withdrawn / held privately pending issue assignment #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yodakkak wants to merge 1 commit into from
Closed

Withdrawn / held privately pending issue assignment #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 65 additions & 73 deletions src/routes/indexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,104 +1,96 @@
const express = require('express');
const eventStore = require('../indexer/eventStore');
const indexerPoller = require('../indexer/runtime');
const logger = require('../logger');
const AppError = require('../errors/AppError');
const buildRateLimit = require('../middleware/rateLimit');
const { parsePagination, paginateResponse } = require('../utils/paginate');
const express = require("express");
const eventStore = require("../indexer/eventStore");
const indexerPoller = require("../indexer/runtime");
const logger = require("../logger");
const AppError = require("../errors/AppError");
const buildRateLimit = require("../middleware/rateLimit");
const { validate } = require("../middleware/validate");
const {
indexerAirdropParamsSchema,
indexerRecipientParamsSchema,
paginationQuerySchema,
} = require("../validation/schemas");
const { parsePagination, paginateResponse } = require("../utils/paginate");

const router = express.Router();
const validateAirdropParams = validate(indexerAirdropParamsSchema, "params");
const validateRecipientParams = validate(indexerRecipientParamsSchema, "params");
const validatePaginationQuery = validate(paginationQuerySchema, "query");

function isValidId(value) {
return typeof value === 'string' && /^[A-Za-z0-9:_-]{1,128}$/.test(value);
}

function isValidAddress(value) {
return typeof value === 'string' && /^[A-Z0-9]{10,80}$/.test(value);
}

router.get('/airdrops/:id/status', async (req, res, next) => {
router.get("/airdrops/:id/status", validateAirdropParams, async (req, res, next) => {
try {
if (!isValidId(req.params.id)) {
return next(new AppError('VALIDATION_ERROR', 'Invalid airdrop id', 400, { param: 'id' }));
}

const status = await eventStore.getAirdropStatus(req.params.id);
const { id } = req.validated.params;
const status = await eventStore.getAirdropStatus(id);
if (!status) {
return next(new AppError('AIRDROP_NOT_INDEXED', 'Airdrop has not been indexed', 404, {
airdrop_id: req.params.id,
}));
return next(
new AppError("AIRDROP_NOT_INDEXED", "Airdrop has not been indexed", 404, {
airdrop_id: id,
})
);
}

return res.json(status);
} catch (err) {
logger.error('Airdrop status lookup failed', { error: err.message });
logger.error("Airdrop status lookup failed", { error: err.message });
return next(err);
}
});

// Named distinctly from airdrops.js's own `/airdrops/:id/recipients` (the
// stored/intended recipient list): this returns recipients derived from
// indexed on-chain claim events, a different source of truth. The two
// routers previously registered the exact same path, and since this
// router is mounted first in src/index.js, it silently shadowed the real
// listRecipients handler in airdrops.js on every request.
// getAirdropRecipients/getRecipientClaims below fully materialize their
// list from a single Redis key regardless (see eventStore.js's
// getJsonList) — there's no server-side "fetch only a page" available at
// the storage layer, so pagination here is a slice of the already-fetched
// array plus the canonical envelope, not a more efficient query (#131).
router.get('/airdrops/:id/onchain-recipients', async (req, res, next) => {
try {
if (!isValidId(req.params.id)) {
return next(new AppError('VALIDATION_ERROR', 'Invalid airdrop id', 400, { param: 'id' }));
router.get(
"/airdrops/:id/onchain-recipients",
validateAirdropParams,
validatePaginationQuery,
async (req, res, next) => {
try {
const { id } = req.validated.params;
const allRecipients = await eventStore.getAirdropRecipients(id);
const { page, limit } = parsePagination(req.query);
const start = (page - 1) * limit;
const pageRecipients = allRecipients.slice(start, start + limit);
return res.json(paginateResponse(pageRecipients, allRecipients.length, { page, limit }));
} catch (err) {
logger.error("Airdrop recipients lookup failed", { error: err.message });
return next(err);
}

const allRecipients = await eventStore.getAirdropRecipients(req.params.id);
const { page, limit } = parsePagination(req.query);
const start = (page - 1) * limit;
const pageRecipients = allRecipients.slice(start, start + limit);
return res.json(paginateResponse(pageRecipients, allRecipients.length, { page, limit }));
} catch (err) {
logger.error('Airdrop recipients lookup failed', { error: err.message });
return next(err);
}
});
);

router.get('/recipients/:address/claims', async (req, res, next) => {
try {
if (!isValidAddress(req.params.address)) {
return next(new AppError('VALIDATION_ERROR', 'Invalid recipient address', 400, {
param: 'address',
}));
router.get(
"/recipients/:address/claims",
validateRecipientParams,
validatePaginationQuery,
async (req, res, next) => {
try {
const { address } = req.validated.params;
const allClaims = await eventStore.getRecipientClaims(address);
const { page, limit } = parsePagination(req.query);
const start = (page - 1) * limit;
const pageClaims = allClaims.slice(start, start + limit);
return res.json(paginateResponse(pageClaims, allClaims.length, { page, limit }));
} catch (err) {
logger.error("Recipient claims lookup failed", { error: err.message });
return next(err);
}

const allClaims = await eventStore.getRecipientClaims(req.params.address);
const { page, limit } = parsePagination(req.query);
const start = (page - 1) * limit;
const pageClaims = allClaims.slice(start, start + limit);
return res.json(paginateResponse(pageClaims, allClaims.length, { page, limit }));
} catch (err) {
logger.error('Recipient claims lookup failed', { error: err.message });
return next(err);
}
});
);

const indexerStatusLimit = buildRateLimit({
windowSeconds: 1,
max: 1,
keyPrefix: 'indexer-status',
keyPrefix: "indexer-status",
});

router.get('/indexer/status', indexerStatusLimit, async (_req, res, next) => {
router.get("/indexer/status", indexerStatusLimit, async (_req, res, next) => {
try {
const stats = await eventStore.getStats();
const poller = indexerPoller.getStatus();
const hasLatestLedger = poller.latest_ledger !== null && poller.latest_ledger !== undefined;
const latestLedger = Number(poller.latest_ledger);
const lastLedger = Number(stats.last_ledger);
const ledgerLag = hasLatestLedger && Number.isFinite(latestLedger) && Number.isFinite(lastLedger)
? Math.max(0, latestLedger - lastLedger)
: null;
const ledgerLag =
hasLatestLedger && Number.isFinite(latestLedger) && Number.isFinite(lastLedger)
? Math.max(0, latestLedger - lastLedger)
: null;

return res.json({
...poller,
Expand All @@ -108,9 +100,9 @@ router.get('/indexer/status', indexerStatusLimit, async (_req, res, next) => {
ledger_lag: ledgerLag,
});
} catch (err) {
logger.error('Indexer status lookup failed', { error: err.message });
logger.error("Indexer status lookup failed", { error: err.message });
return next(err);
}
});

module.exports = router;
module.exports = router;
Loading