Skip to content

[bug] farming-pool: unlock_assets doesn't emit credits_earned event #381

Closed

Description

@ritaifeoluwa

Problem

unlock_assets returns total credits but doesn't emit an event with the credits earned. Indexers cannot track credit distributions.

Impact

  • Off-chain systems cannot track credit distributions
  • No audit trail for credit earnings
  • Credit analytics require storage scans

Fix

Add an event emission:

env.events().publish(
    (symbol_short!("pool"), symbol_short!("credits_earned")),
    (user, amount, total_credits),
);

Location

contracts/farming-pool/src/lib.rs, unlock_assets function, after line 500.

Activity

  1. ibiajnr commented on Sep 27, 2026

    @ibiajnr

    @ibiajnr has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I have reviewed the issue, and i am very very confident that i am capable, and i can fix it if the task is given to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @ibiajnr to this issue.

  2. Olamidecare commented on Sep 27, 2026

    @Olamidecare

    @Olamidecare has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi Maintainer! I’m interested in contributing to this task and would be glad to work on it. I’m committed to delivering a clean, well-tested solution within the expected timeline.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Olamidecare to this issue.

  3. Enchanterme commented on Sep 27, 2026

    @Enchanterme

    @Enchanterme has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Can i work on this task?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Enchanterme to this issue.

  4. drips-wave commented on Sep 27, 2026

    @drips-wave

    Congratulations, @Enchanterme! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @Enchanterme: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Sep 27, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Enchanterme's PR #426 was approved and merged by @ritaifeoluwa.

    🏆 @Enchanterme: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (376 total points). Track your full progress on GrantFox.

    👏 Great work, @Enchanterme! Keep contributing to SmartDropLabs.

  6. drips-wave commented on Sep 27, 2026

    @drips-wave

    This issue has been completed by @Enchanterme as part of the Stellar Wave Program's 9th Wave 🥳

    😎 @Enchanterme: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingfarming-poolFarmingPool contract

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions