Repository navigation
fix(security): cover inline scripts with CSP nonces and hashes - #662
Open
Mainnet-ops wants to merge 1 commit into
Open
Mainnet-ops wants to merge 1 commit into
Mainnet-ops wants to merge 1 commit into
Conversation
Inline scripts were not covered by the Content-Security-Policy: - Server mode: the middleware generated a nonce but only forwarded it as `x-nonce`. Next.js reads the nonce from the request's Content-Security-Policy header, so its own inline scripts (RSC payload, bootstrap) were emitted without a nonce. The middleware now forwards the CSP on the request headers. - Static export: the <meta> CSP from next.config.ts had a bare `script-src 'self'` with no nonce or hash for any inline script. A new post-build step (scripts/csp-hash-inline-scripts.mjs, run by `npm run build` when NEXT_EXPORT=true) hashes every inline <script> in each exported page and adds its 'sha256-…' source to that page's meta CSP. The policy is now built in one place (src/config/csp.ts) and used by both next.config.ts and the middleware, so the two can't drift apart. 'unsafe-inline' is never allowed for scripts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Mainnet-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
❌ Deploy Preview for smart-drop failed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline scripts were not covered by the Content-Security-Policy:
x-nonce. Next.js reads the nonce from the request's Content-Security-Policy header, so its own inline scripts (RSC payload, bootstrap) were emitted without a nonce. The middleware now forwards the CSP on the request headers.script-src 'self'with no nonce or hash for any inline script. A new post-build step (scripts/csp-hash-inline-scripts.mjs, run bynpm run buildwhen NEXT_EXPORT=true) hashes every inline <script> in each exported page and adds its 'sha256-…' source to that page's meta CSP.The policy is now built in one place (src/config/csp.ts) and used by both next.config.ts and the middleware, so the two can't drift apart. 'unsafe-inline' is never allowed for scripts.
Closes #640
Closes #641
Closes #643
Closes #644