Repository navigation
Fix marketing attribution verifier source schema on DuckDB - #13
Open
lluisinthedesert wants to merge 1 commit into
Open
lluisinthedesert wants to merge 1 commit into
lluisinthedesert wants to merge 1 commit into
Conversation
lluisinthedesert
marked this pull request as ready for review
October 21, 2026 04:21
sfc-gh-dhuang
approved these changes
Nov 11, 2026
sfc-gh-dhuang
left a comment
Collaborator
There was a problem hiding this comment.
thanks for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DuckDB verifier for
dbt-fix-marketing-attributionreads GA staging relations fromanalytics, although the supplied reference builds them inmain. The shipped reference consequently fails four verifier tests with missing-table errors.SCHEMAdescribes the output location:analyticson DuckDB andmainon Snowflake. AssigningSOURCE_SCHEMA = SCHEMAincorrectly applies that output location to the source relations. SetSOURCE_SCHEMA = 'main'instead; output checks still useSCHEMA.This agrees with the task's
instruction.md:48, which warns that reference staging models materialize inmain, and with the siblingdbt-fix-paid-search-attributionverifier, which readsmain.stg_ga__sessionswhile checking output inanalytics.Reproduction
At
a3278ad102829a6084dde086244a0ef665a8011c, run this task's referencesolution/solve.shwithDB_TYPE=duckdb, thenpytest tests/test_outputs.pyin the prepared task environment. The reference builds successfully, but these four tests fail becauseanalytics.stg_ga__sessionsdoes not exist:test_conversion_logictest_aggregationtest_date_filtertest_matches_source_reconciliationValidation
Executed the shipped reference and task verifier in isolated local projects on macOS arm64 with Python 3.12, dbt-core 1.10.23, dbt-duckdb 1.10.0, and dbt-snowflake 1.10.0. Container paths were remapped locally. Snowflake pairings used separate database clones with the task's required source dependencies loaded from the pinned dataset. These are direct dbt/pytest checks, not Harbor agent runs.
One line in the verifier changes. No changes to the reference solution, instructions, source data, output schema, or revenue logic.