Repository navigation
Prevent supplier-scorecard verifier crashes on suppliers outside the comparison set - #17
Merged
sfc-gh-dhuang merged 1 commit intoNov 12, 2026
Conversation
sfc-gh-dhuang
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three supplier-scorecard source comparisons convert metrics to numbers before checking whether the supplier has a source expectation. A supplier outside that comparison set can therefore crash verification when its metrics are NULL, even though the following guard would skip the row.
Changes
1. Apply the existing comparison scope before numeric conversion (
fix)Scope: supplier-scorecard grading | Impact: benchmark reliability
Move delivery, quality, and cost metric conversions inside their existing source-membership guards.
Validation
On upstream a3278ad, the new regression checks produce 3 failed, 9 passed before the fix and 12 passed afterward, with no skips. The three original failures are the actual numeric-conversion exceptions in the verifier. New regression code passes Ruff.
The checks call the actual verifier comparison methods with controlled rows and source expectations. They do not run dbt, a live warehouse, a Harbor trial, or an agent. No overall task-score increase or complete live task-suite pass is claimed.
Migration / Breaking Changes
None.
Changelog Notes
Refs