SONARJAVA-6623 Revert Tomcat 11 upgrade#5793
Merged
Merged
Conversation
… to v11" This reverts commit 6ce0008 and constrains Renovate to Tomcat 9 because JSP analysis still relies on Java EE APIs.
Contributor
Code Review ✅ ApprovedReverts the Tomcat 11 migration to restore compatibility with Java EE APIs and Tomcat 9, ensuring stable JSP analysis and license generation. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
org.apache.tomcatMaven dependencies to 9.x in RenovateWhy
Tomcat 10 and later use Jakarta APIs, while JSP analysis still relies on the Java EE APIs supplied by Tomcat 9. The follow-up servlet API update in #5792 also fails license generation and would remove the expected
javax.servletclasses.After this merges, Renovate should close #5792 as no longer permitted by the repository configuration.
Verification
renovate-config-validator .github/renovate.jsonmvn clean test -pl java-frontend,java-jsp,sonar-java-plugin -am(13 modules, BUILD SUCCESS)Summary by Gitar
autoScanClasspathwithglobalClasspathinJavaFrontendto ensure consistent classpath usage.JspCodeCheckto identify method invocations using line numbers instead of potentially ambiguous method names.spring-webmvcto5.2.3.RELEASEinjava-jsp/pom.xml.getIeClassIdoverride inJasperOptionsto maintain compatibility with legacy JSP configurations.JasperTestto point to the correctspring-webmvc-5.2.3.RELEASE.jartest dependency.This will update automatically on new commits.