Skip to content

SONARJAVA-6623 Revert Tomcat 11 upgrade#5793

Merged
vdiez merged 1 commit into
masterfrom
codex/revert-tomcat-11
Jul 15, 2026
Merged

SONARJAVA-6623 Revert Tomcat 11 upgrade#5793
vdiez merged 1 commit into
masterfrom
codex/revert-tomcat-11

Conversation

@vdiez

@vdiez vdiez commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

Tomcat 10 and later use Jakarta APIs, while JSP analysis still relies on the Java EE APIs supplied by Tomcat 9. The follow-up servlet API update in #5792 also fails license generation and would remove the expected javax.servlet classes.

After this merges, Renovate should close #5792 as no longer permitted by the repository configuration.

Verification

  • renovate-config-validator .github/renovate.json
  • Java 26: mvn clean test -pl java-frontend,java-jsp,sonar-java-plugin -am (13 modules, BUILD SUCCESS)

Summary by Gitar

  • Refactored internal logic:
    • Replaced autoScanClasspath with globalClasspath in JavaFrontend to ensure consistent classpath usage.
    • Updated JspCodeCheck to identify method invocations using line numbers instead of potentially ambiguous method names.
  • Updated dependencies and configuration:
    • Downgraded spring-webmvc to 5.2.3.RELEASE in java-jsp/pom.xml.
    • Added getIeClassId override in JasperOptions to maintain compatibility with legacy JSP configurations.
  • Cleaned up tests:
    • Updated JasperTest to point to the correct spring-webmvc-5.2.3.RELEASE.jar test dependency.

This will update automatically on new commits.

… to v11"

This reverts commit 6ce0008 and constrains Renovate to Tomcat 9 because JSP analysis still relies on Java EE APIs.
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Revert Tomcat 11 upgrade SONARJAVA-6623 Revert Tomcat 11 upgrade Jul 15, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6623

@gitar-bot

gitar-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Reverts the Tomcat 11 migration to restore compatibility with Java EE APIs and Tomcat 9, ensuring stable JSP analysis and license generation. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next

Copy link
Copy Markdown

@vdiez vdiez enabled auto-merge (squash) July 15, 2026 08:04
@vdiez vdiez merged commit 394a220 into master Jul 15, 2026
18 checks passed
@vdiez vdiez deleted the codex/revert-tomcat-11 branch July 15, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants