Repository navigation
fix: repair tokenizeCSVLine trailing-token bug, add BigInt amount sum, escape CSV export - #1003
Merged
k-deejah merged 1 commit intoOct 18, 2026
Conversation
…, escape CSV export Closes Sorokit#899 Closes Sorokit#901 Closes Sorokit#898 Closes Sorokit#896
|
@unlimitedengineer Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #899
Closes #901
Closes #898
Closes #896
Summary
BatchPaymentProcessor:tokenizeCSVLinetrailing-token bug — thewhile (i <= line.length)loop unconditionally pushed an extra""token at the end of every line, silently misaligning column reads for rows without trailing commas. Fixed: the trailing push now only fires whenline[i - 1] === ',', so a genuine empty final field is preserved while phantom tokens are eliminated.sumAmountsStroops(amounts: string[]): stringwhich converts each decimal amount to stroops (×10⁷), sums exactly withBigInt, then formats back to a decimal string — no IEEE-754 drift.downloadCSVReportnow routes every field throughescapeCSVField, which wraps fields containing commas, quotes, or newlines in double-quotes and escapes internal quotes as"".Changes
src/components/BatchPaymentProcessor.tsx— fixedtokenizeCSVLine, addedsumAmountsStroopsexport, addedescapeCSVField, updateddownloadCSVReportsrc/components/BatchPaymentProcessor.test.tsx— 7 new tests: 3 for empty/missing memo parsing, 4 forsumAmountsStroopsprecision