Repository navigation
fix(WalletStatusBadge): resolve status display and contrast issues (#888) - #1008
Merged
k-deejah merged 4 commits intoOct 18, 2026
Merged
Conversation
…orokit#888) - Support transient network re-synchronization ('connecting') with a pulsating yellow indicator and 'Reconnecting...' label - Add 'error' state mapping to STATUS_STYLES with distinct badge indicator - Calibrate status text tokens to satisfy WCAG 2.1 AA contrast requirements (>= 4.5:1) in dark mode - Author tests in WalletStatusBadge.test.tsx covering all four lifecycle states and WCAG contrast
|
@bamiebot-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #888.
Problem
networkStatus === 'connecting') was in progress,WalletStatusBadgewas falling back to rendering the green "Connected" status dot without any status label.bg-surface-2in dark mode.disconnected->connecting->connected->error).Solution & Implementation
connectingstate toSTATUS_STYLESwith a pulsating yellow indicator (bg-yellow-400 motion-safe:animate-pulse) and"Reconnecting..."label. Also factors inisSwitchingNetworkduring active transitions.errorstate toSTATUS_STYLESwith a distinct red dot (bg-red) and"Error"label.bg-surface-2(#1c1c1c):connecting:text-yellow-400(~10.85:1 contrast)degraded:text-warning(#fdba74, ~9.67:1 contrast)offline/error:text-red-400(#f87171, ~5.85:1 contrast)text-ink-2(#999999, ~5.56:1 contrast)src/components/WalletStatusBadge.test.tsxto test:"Reconnecting..."label and accessible ARIA attributes"Error"labeldisconnected->connecting->connected->error)Acceptance Criteria Checklist
WalletStatusBadge.test.tsxtests all four network lifecycle states.