Repository navigation
Modify Settings into singleton, graphical update for settings switches - #117
Merged
Merged
Conversation
…relying on exception
Contributor
Author
|
Also noting #116 , hack to serialize static class will no longer be needed. |
Member
|
@Adam1213 could you fix the merge conflict? If you're busy, I can try my best. |
Contributor
Author
Done, lmk if there is something else to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how
Settingsclass works with WPF.Settingsis now a singleton instead of static class and properties change using bindings instead of events. Setting switches got reworked to deduplicate code and ease style changes.From other changes:
EnableDebugsetting is now a property, with extra logic to exclude it from debug logsMay conflict with #114